Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issue 1968123002: Revert of Improve handling of PaintInvalidationLayer (renamed to PaintInvalidationSubtree) (Closed)

Created:
4 years, 7 months ago by prasadv
Modified:
4 years, 7 months ago
Reviewers:
chrishtr, Xianzhu
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-style_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), jbroman, jchaffraix+rendering, Justin Novosad, kinuko+watch, leviw+renderwatch, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@LocationChange
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Improve handling of PaintInvalidationLayer (renamed to PaintInvalidationSubtree) (patchset #9 id:160001 of https://codereview.chromium.org/1950573003/ ) Reason for revert: [Perf bot health sheriff]Breaking blink_perf.css benchmarks on chromium.perf waterfall. Original issue's description: > Improve handling of PaintInvalidationLayer > > Rename PaintInvalidationLayer to PaintInvalidationSubtree. > > In LayoutObject::setShouldDoFullPaintInvalidationIncludingNonCompositingDescendants(), > instead of traverse the tree to setShouldDoFullPaintInvalidation(), set > PaintInvalidationSubtree on the root of the subtree. > > During paint invalidation, if a LayoutObject is marked > PaintInvalidationSubtree, force full paint invalidation of the subtree > (within the paintInvalidationContainer). > > BUG=410097 > > Committed: https://crrev.com/2848739b13b1f454930307439ba00ddd55bb9b40 > Cr-Commit-Position: refs/heads/master@{#392861} TBR=chrishtr@chromium.org,wangxianzhu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=410097 Committed: https://crrev.com/0852aad4140cdb8019a95679e3f31e895b61652b Cr-Commit-Position: refs/heads/master@{#392958}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -186 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 2 chunks +2 lines, -81 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 3 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 9 chunks +29 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.h View 3 chunks +7 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp View 5 chunks +20 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleDifference.h View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/PaintInvalidationReason.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/PaintInvalidationReason.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
prasadv
Created Revert of Improve handling of PaintInvalidationLayer (renamed to PaintInvalidationSubtree)
4 years, 7 months ago (2016-05-11 16:59:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968123002/1
4 years, 7 months ago (2016-05-11 17:00:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 17:01:00 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0852aad4140cdb8019a95679e3f31e895b61652b Cr-Commit-Position: refs/heads/master@{#392958}
4 years, 7 months ago (2016-05-11 17:03:30 UTC) #5
Xianzhu
4 years, 7 months ago (2016-05-11 17:21:06 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1970843002/ by wangxianzhu@chromium.org.

The reason for reverting is: This will break waterfall without rebaseline
reverted.

Will try to fix the bot instead..

Powered by Google App Engine
This is Rietveld 408576698