Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1968113002: Fix include path for moved thread_task_runner_handle.h header in blimp/ (Closed)

Created:
4 years, 7 months ago by gab
Modified:
4 years, 7 months ago
Reviewers:
Kevin M
CC:
chromium-reviews, cbentzel+watch_chromium.org, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@a1_move_task_runner_handle
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix include path for moved thread_task_runner_handle.h header in blimp/ Also fix presubmit error in engine_authentication_handler_unittest.cc for using static string instead of const char[] BUG=610438 TBR=kmarshall@chromium.org Committed: https://crrev.com/a92eb980f55441d7acf99ab92c2561409fafc56f Cr-Commit-Position: refs/heads/master@{#392974}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M blimp/client/app/android/blimp_client_session_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/app/linux/blimp_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/feature/compositor/blimp_compositor.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/feature/compositor/blimp_compositor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/session/assignment_source_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/session/blimp_client_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/engine/session/blimp_engine_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/net/blimp_message_checkpointer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/net/engine_authentication_handler_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
gab
TBR kmarshall for header rename side-effects on blimp/
4 years, 7 months ago (2016-05-11 16:48:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968113002/1
4 years, 7 months ago (2016-05-11 16:48:25 UTC) #5
Kevin M
lgtm Thanks!
4 years, 7 months ago (2016-05-11 16:51:17 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 17:35:10 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 17:36:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a92eb980f55441d7acf99ab92c2561409fafc56f
Cr-Commit-Position: refs/heads/master@{#392974}

Powered by Google App Engine
This is Rietveld 408576698