Move base/thread_task_runner_handle.h to base/threading/thread_task_runner_handle.h

Move base/thread_task_runner_handle.h to base/threading/thread_task_runner_handle.h

Keeping a base/thread_task_runner_handle.h which
merely does a direct mapping behind for now.

Will then proceed to incrementally fixing >1500 files that
include the old path (TBR'ing to component OWNERS) to eventually
get rid of it.

BUG=610438
Committed: https://crrev.com/0ac3fff261825d90beb0b8111fa7499d73bcac7c
Cr-Commit-Position: refs/heads/master@{#392765}

[gab, 2016-05-10 18:53:02]

Description was changed from

==========
Move base/thread_task_runner_handle.h to
base/threading/thread_task_runner_handle.h

BUG=610438
==========

to

==========
Move base/thread_task_runner_handle.h to
base/threading/thread_task_runner_handle.h

Keeping a base/thread_task_runner_handle.h which
merely does a direct mapping behind for now.

Will then proceed to incrementally fixing places that
include the old path and get rid of it.

BUG=610438
==========

[gab, 2016-05-10 18:53:42]

gab@chromium.org changed reviewers:
+ danakj@chromium.org

[gab, 2016-05-10 18:53:43]

Dana PTAL, simple move, thanks

[gab, 2016-05-10 18:54:18]

On 2016/05/10 18:53:43, gab wrote:
> Dana PTAL, simple move, thanks

Oops forgot GYP/GN, coming up.

[gab, 2016-05-10 18:59:06]

On 2016/05/10 18:54:18, gab wrote:
> On 2016/05/10 18:53:43, gab wrote:
> > Dana PTAL, simple move, thanks
> 
> Oops forgot GYP/GN, coming up.

Done, @dana PTAL, thanks

[gab, 2016-05-10 19:00:09]

Description was changed from

==========
Move base/thread_task_runner_handle.h to
base/threading/thread_task_runner_handle.h

Keeping a base/thread_task_runner_handle.h which
merely does a direct mapping behind for now.

Will then proceed to incrementally fixing places that
include the old path and get rid of it.

BUG=610438
==========

to

==========
Move base/thread_task_runner_handle.h to
base/threading/thread_task_runner_handle.h

Keeping a base/thread_task_runner_handle.h which
merely does a direct mapping behind for now.

Will then proceed to incrementally fixing places that
include the old path (TBR'ing to root OWNERS) to eventually
get rid of it.

BUG=610438
==========

[gab, 2016-05-10 19:00:23]

Description was changed from

==========
Move base/thread_task_runner_handle.h to
base/threading/thread_task_runner_handle.h

Keeping a base/thread_task_runner_handle.h which
merely does a direct mapping behind for now.

Will then proceed to incrementally fixing places that
include the old path (TBR'ing to root OWNERS) to eventually
get rid of it.

BUG=610438
==========

to

==========
Move base/thread_task_runner_handle.h to
base/threading/thread_task_runner_handle.h

Keeping a base/thread_task_runner_handle.h which
merely does a direct mapping behind for now.

Will then proceed to incrementally fixing places that
include the old path (TBR'ing to component OWNERS) to eventually
get rid of it.

BUG=610438
==========

[gab, 2016-05-10 19:00:45]

Description was changed from

==========
Move base/thread_task_runner_handle.h to
base/threading/thread_task_runner_handle.h

Keeping a base/thread_task_runner_handle.h which
merely does a direct mapping behind for now.

Will then proceed to incrementally fixing places that
include the old path (TBR'ing to component OWNERS) to eventually
get rid of it.

BUG=610438
==========

to

==========
Move base/thread_task_runner_handle.h to
base/threading/thread_task_runner_handle.h

Keeping a base/thread_task_runner_handle.h which
merely does a direct mapping behind for now.

Will then proceed to incrementally fixing >1500 files that
include the old path (TBR'ing to component OWNERS) to eventually
get rid of it.

BUG=610438
==========

[danakj, 2016-05-10 20:17:38]

https://codereview.chromium.org/1966733002/diff/20001/base/threading/thread_t...
File base/threading/thread_task_runner_handle.h (right):

https://codereview.chromium.org/1966733002/diff/20001/base/threading/thread_t...
base/threading/thread_task_runner_handle.h:1: // Copyright (c) 2012 The Chromium
Authors. All rights reserved.
2016, no (c)

https://codereview.chromium.org/1966733002/diff/20001/base/threading/thread_t...
base/threading/thread_task_runner_handle.h:5: #ifndef
BASE_THREAD_TASK_RUNNER_HANDLE_H_
BASE_THREADING_...

[danakj, 2016-05-10 20:17:48]

https://codereview.chromium.org/1966733002/diff/20001/base/threading/thread_t...
File base/threading/thread_task_runner_handle.cc (right):

https://codereview.chromium.org/1966733002/diff/20001/base/threading/thread_t...
base/threading/thread_task_runner_handle.cc:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
ditto

[chromium-reviews, 2016-05-10 20:29:42]

Ah, figured I wouldn't update the date for a move (just as we're don't when
modifying a file) but happy to if you prefer.

Le mar. 10 mai 2016 16:17, <danakj@chromium.org> a écrit :

>
>
>
https://codereview.chromium.org/1966733002/diff/20001/base/threading/thread_t...
> File base/threading/thread_task_runner_handle.cc (right):
>
>
>
https://codereview.chromium.org/1966733002/diff/20001/base/threading/thread_t...
> base/threading/thread_task_runner_handle.cc:1: // Copyright (c) 2012 The
>
> Chromium Authors. All rights reserved.
> ditto
>
> https://codereview.chromium.org/1966733002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[danakj, 2016-05-10 20:47:20]

On Tue, May 10, 2016 at 1:29 PM, Gabriel Charette <gab@google.com> wrote:

> Ah, figured I wouldn't update the date for a move (just as we're don't
> when modifying a file) but happy to if you prefer.
>
Shrug, I think I do? But you do need to fix the include guard.



>
> Le mar. 10 mai 2016 16:17, <danakj@chromium.org> a écrit :
>
>>
>>
>>
https://codereview.chromium.org/1966733002/diff/20001/base/threading/thread_t...
>> File base/threading/thread_task_runner_handle.cc (right):
>>
>>
>>
https://codereview.chromium.org/1966733002/diff/20001/base/threading/thread_t...
>> base/threading/thread_task_runner_handle.cc:1: // Copyright (c) 2012 The
>>
>> Chromium Authors. All rights reserved.
>> ditto
>>
>> https://codereview.chromium.org/1966733002/
>>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[gab, 2016-05-10 21:44:52]

All done :-)

https://codereview.chromium.org/1966733002/diff/20001/base/threading/thread_t...
File base/threading/thread_task_runner_handle.cc (right):

https://codereview.chromium.org/1966733002/diff/20001/base/threading/thread_t...
base/threading/thread_task_runner_handle.cc:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
On 2016/05/10 20:17:47, danakj wrote:
> ditto

Done.

https://codereview.chromium.org/1966733002/diff/20001/base/threading/thread_t...
File base/threading/thread_task_runner_handle.h (right):

https://codereview.chromium.org/1966733002/diff/20001/base/threading/thread_t...
base/threading/thread_task_runner_handle.h:1: // Copyright (c) 2012 The Chromium
Authors. All rights reserved.
On 2016/05/10 20:17:38, danakj wrote:
> 2016, no (c)

Done.

https://codereview.chromium.org/1966733002/diff/20001/base/threading/thread_t...
base/threading/thread_task_runner_handle.h:5: #ifndef
BASE_THREAD_TASK_RUNNER_HANDLE_H_
On 2016/05/10 20:17:38, danakj wrote:
> BASE_THREADING_...

Done.

[danakj, 2016-05-10 21:47:09]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[danakj, 2016-05-10 21:47:27]

Thanks LGTM does that header change fix the red bots?

[commit-bot: I haz the power, 2016-05-10 21:47:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1966733002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1966733002/40001

[gab, 2016-05-10 21:51:57]

On 2016/05/10 21:47:27, danakj wrote:
> Thanks LGTM does that header change fix the red bots?

Assume so yes, they couldn't find the definition of ThreadTaskRunnerHandle since
the identical include guards made the forward inclusion in the old header be a
no-op..!

Thanks!

[gab, 2016-05-10 21:52:06]

The CQ bit was checked by gab@chromium.org

[gab, 2016-05-10 21:52:07]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1966733002/#ps60001
(title: "update include of .cc to be direct")

[commit-bot: I haz the power, 2016-05-10 21:52:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1966733002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1966733002/60001

[commit-bot: I haz the power, 2016-05-10 23:17:15]

Description was changed from

==========
Move base/thread_task_runner_handle.h to
base/threading/thread_task_runner_handle.h

Keeping a base/thread_task_runner_handle.h which
merely does a direct mapping behind for now.

Will then proceed to incrementally fixing >1500 files that
include the old path (TBR'ing to component OWNERS) to eventually
get rid of it.

BUG=610438
==========

to

==========
Move base/thread_task_runner_handle.h to
base/threading/thread_task_runner_handle.h

Keeping a base/thread_task_runner_handle.h which
merely does a direct mapping behind for now.

Will then proceed to incrementally fixing >1500 files that
include the old path (TBR'ing to component OWNERS) to eventually
get rid of it.

BUG=610438
==========

[commit-bot: I haz the power, 2016-05-10 23:17:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-10 23:18:32]

Description was changed from

==========
Move base/thread_task_runner_handle.h to
base/threading/thread_task_runner_handle.h

Keeping a base/thread_task_runner_handle.h which
merely does a direct mapping behind for now.

Will then proceed to incrementally fixing >1500 files that
include the old path (TBR'ing to component OWNERS) to eventually
get rid of it.

BUG=610438
==========

to

==========
Move base/thread_task_runner_handle.h to
base/threading/thread_task_runner_handle.h

Keeping a base/thread_task_runner_handle.h which
merely does a direct mapping behind for now.

Will then proceed to incrementally fixing >1500 files that
include the old path (TBR'ing to component OWNERS) to eventually
get rid of it.

BUG=610438

Committed: https://crrev.com/0ac3fff261825d90beb0b8111fa7499d73bcac7c
Cr-Commit-Position: refs/heads/master@{#392765}
==========

[commit-bot: I haz the power, 2016-05-10 23:18:33]

Patchset 4 (id:??) landed as
https://crrev.com/0ac3fff261825d90beb0b8111fa7499d73bcac7c
Cr-Commit-Position: refs/heads/master@{#392765}