Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1968013002: [Smart Lock] Adds UMA Metrics for buttons clicks in Auto-signin FRE. (Closed)

Created:
4 years, 7 months ago by melandory
Modified:
4 years, 7 months ago
Reviewers:
vasilii
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock] Adds UMA Metrics for buttons clicks in Auto-signin FRE. Adds UMA metrics for tracking "Turn Off" and "Ok, got it" buttons in Auto sign-in first run experience for the CM API. BUG=610975 Committed: https://crrev.com/b53d8f6104063f23f369f0a2c90aecd0b048be1f Cr-Commit-Position: refs/heads/master@{#392898}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M chrome/browser/password_manager/auto_signin_first_run_dialog_android.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/auto_signin_first_run_dialog_android_unittest.cc View 4 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
melandory
PTAL, thanks!
4 years, 7 months ago (2016-05-11 10:52:51 UTC) #2
vasilii
The decryption is unclear. It should be something like "Add UMA metrics...". Why don't you ...
4 years, 7 months ago (2016-05-11 11:09:53 UTC) #5
melandory
On 2016/05/11 11:09:53, vasilii wrote: > The decryption is unclear. It should be something like ...
4 years, 7 months ago (2016-05-11 11:15:00 UTC) #6
melandory
On 2016/05/11 11:09:53, vasilii wrote: > The decryption is unclear. It should be something like ...
4 years, 7 months ago (2016-05-11 11:16:45 UTC) #8
vasilii
lgtm
4 years, 7 months ago (2016-05-11 11:17:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968013002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968013002/40001
4 years, 7 months ago (2016-05-11 11:19:12 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 7 months ago (2016-05-11 11:22:42 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 11:25:24 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b53d8f6104063f23f369f0a2c90aecd0b048be1f
Cr-Commit-Position: refs/heads/master@{#392898}

Powered by Google App Engine
This is Rietveld 408576698