Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2332)

Unified Diff: chrome/browser/password_manager/auto_signin_first_run_dialog_android_unittest.cc

Issue 1968013002: [Smart Lock] Adds UMA Metrics for buttons clicks in Auto-signin FRE. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/password_manager/auto_signin_first_run_dialog_android.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/auto_signin_first_run_dialog_android_unittest.cc
diff --git a/chrome/browser/password_manager/auto_signin_first_run_dialog_android_unittest.cc b/chrome/browser/password_manager/auto_signin_first_run_dialog_android_unittest.cc
index e98121e4bf1e1b0eafe159384f32c0356b342ede..6317b6befe7a2bca6fc79bd44fb9bdee88d37643 100644
--- a/chrome/browser/password_manager/auto_signin_first_run_dialog_android_unittest.cc
+++ b/chrome/browser/password_manager/auto_signin_first_run_dialog_android_unittest.cc
@@ -3,9 +3,11 @@
// found in the LICENSE file.
#include "base/macros.h"
+#include "base/test/histogram_tester.h"
#include "chrome/browser/password_manager/auto_signin_first_run_dialog_android.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/test/base/chrome_render_view_host_test_harness.h"
+#include "components/password_manager/core/browser/password_manager_metrics_util.h"
#include "components/password_manager/core/common/password_manager_pref_names.h"
#include "components/prefs/pref_service.h"
#include "content/public/browser/web_contents.h"
@@ -52,6 +54,7 @@ TEST_F(AutoSigninFirstRunDialogAndroidTest,
TEST_F(AutoSigninFirstRunDialogAndroidTest,
CheckResetOfPrefAfterFirstRunMessageWasShownOnTurnOkClicked) {
+ base::HistogramTester histogram_tester;
prefs()->SetBoolean(
password_manager::prefs::kWasAutoSignInFirstRunExperienceShown, false);
prefs()->SetBoolean(password_manager::prefs::kCredentialsEnableAutosignin,
@@ -63,10 +66,14 @@ TEST_F(AutoSigninFirstRunDialogAndroidTest,
password_manager::prefs::kWasAutoSignInFirstRunExperienceShown));
EXPECT_TRUE(prefs()->GetBoolean(
password_manager::prefs::kCredentialsEnableAutosignin));
+ histogram_tester.ExpectUniqueSample(
+ "PasswordManager.AutoSigninFirstRunDialog",
+ password_manager::metrics_util::AUTO_SIGNIN_OK_GOT_IT, 1);
}
TEST_F(AutoSigninFirstRunDialogAndroidTest,
CheckResetOfPrefAfterFirstRunMessageWasShownOnTurnOffClicked) {
+ base::HistogramTester histogram_tester;
prefs()->SetBoolean(
password_manager::prefs::kWasAutoSignInFirstRunExperienceShown, false);
prefs()->SetBoolean(password_manager::prefs::kCredentialsEnableAutosignin,
@@ -78,4 +85,7 @@ TEST_F(AutoSigninFirstRunDialogAndroidTest,
password_manager::prefs::kWasAutoSignInFirstRunExperienceShown));
EXPECT_FALSE(prefs()->GetBoolean(
password_manager::prefs::kCredentialsEnableAutosignin));
+ histogram_tester.ExpectUniqueSample(
+ "PasswordManager.AutoSigninFirstRunDialog",
+ password_manager::metrics_util::AUTO_SIGNIN_TURN_OFF, 1);
}
« no previous file with comments | « chrome/browser/password_manager/auto_signin_first_run_dialog_android.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698