Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 1968003002: Disable renderToAssociatedSink by default. (Closed)

Created:
4 years, 7 months ago by Guido Urdaneta
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Disable renderToAssociatedSink by default. This flag was actually not working due to a bug. Once that bug was fixed, it apparently triggered another bug in the code that selects associated sinks with some specific audio adapters that create multiple output devices. This is a simple temporary fix so that the original behavior is restored while we fix the actual underlying bug. If this fix works, it will have to be merged into beta and maybe stable. BUG=604523 Review-Url: https://codereview.chromium.org/1956023003 Cr-Commit-Position: refs/heads/master@{#392275} (cherry picked from commit db0441537a40d29d9873fe3a7bba20394d1866cd) Committed: https://chromium.googlesource.com/chromium/src/+/859aa5a6cc983e32d64fd9a3c5f1123fd9e291b9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M content/renderer/media/user_media_client_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/user_media_client_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Guido Urdaneta
4 years, 7 months ago (2016-05-11 08:34:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
859aa5a6cc983e32d64fd9a3c5f1123fd9e291b9.

Powered by Google App Engine
This is Rietveld 408576698