Disable renderToAssociatedSink by default.

Disable renderToAssociatedSink by default.

This flag was actually not working due to a bug. Once that bug was fixed, it
apparently triggered another bug in the code that selects associated sinks with
some specific audio adapters that create multiple output devices.

This is a simple temporary fix so that the original behavior is
restored while we fix the actual underlying bug.

If this fix works, it will have to be merged into beta and maybe stable.

BUG=604523
Committed: https://crrev.com/db0441537a40d29d9873fe3a7bba20394d1866cd
Cr-Commit-Position: refs/heads/master@{#392275}

[Guido Urdaneta, 2016-05-06 21:36:14]

guidou@chromium.org changed reviewers:
+ tommi@chromium.org

[Guido Urdaneta, 2016-05-06 21:36:15]

Hi, PTAL

[tommi (sloooow) - chröme, 2016-05-07 05:14:44]

This may cause big changes to sites that rely on the default behavior. Also "if
it works" doesn't sound very convincing :-\

[Guido Urdaneta, 2016-05-07 08:48:41]

On 2016/05/07 05:14:44, tommi-chrömium wrote:
> This may cause big changes to sites that rely on the default behavior. Also
"if
> it works" doesn't sound very convincing :-\

I don't think anyone is relying on the default value being true.
Before https://codereview.chromium.org/1741553003 the default value was false.

My reasoning is that the real bug is in the AudioManager code that selects
matching devices, but merging a fix for that is probably riskier than just
reverting the default to false.
My plan was to land this on Canary for a few days and revert if anyone
complained.

By "if it works" I actually mean "I think this will work, but I don't have the
hardware to test it so you never know".

[tommi (sloooow) - chröme, 2016-05-08 09:33:03]

lgtm

Ok let's give it a go. I can test tomorrow.

[tommi (sloooow) - chröme, 2016-05-08 09:33:09]

The CQ bit was checked by tommi@chromium.org

[commit-bot: I haz the power, 2016-05-08 09:33:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1956023003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1956023003/1

[commit-bot: I haz the power, 2016-05-08 09:56:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-08 09:56:26]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Guido Urdaneta, 2016-05-08 10:21:35]

The CQ bit was checked by guidou@chromium.org

[Guido Urdaneta, 2016-05-08 10:21:35]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@chromium.org
Link to the patchset: https://codereview.chromium.org/1956023003/#ps20001
(title: "Fix default value in test")

[commit-bot: I haz the power, 2016-05-08 10:21:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1956023003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1956023003/20001

[commit-bot: I haz the power, 2016-05-08 11:33:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-08 11:35:02]

Description was changed from

==========
Disable renderToAssociatedSink by default.

This flag was actually not working due to a bug. Once that bug was fixed, it
apparently triggered another bug in the code that selects associated sinks with
some specific audio adapters that create multiple output devices.

This is a simple temporary fix so that the original behavior is
restored while we fix the actual underlying bug.

If this fix works, it will have to be merged into beta and maybe stable.

BUG=604523
==========

to

==========
Disable renderToAssociatedSink by default.

This flag was actually not working due to a bug. Once that bug was fixed, it
apparently triggered another bug in the code that selects associated sinks with
some specific audio adapters that create multiple output devices.

This is a simple temporary fix so that the original behavior is
restored while we fix the actual underlying bug.

If this fix works, it will have to be merged into beta and maybe stable.

BUG=604523

Committed: https://crrev.com/db0441537a40d29d9873fe3a7bba20394d1866cd
Cr-Commit-Position: refs/heads/master@{#392275}
==========

[commit-bot: I haz the power, 2016-05-08 11:35:03]

Patchset 2 (id:??) landed as
https://crrev.com/db0441537a40d29d9873fe3a7bba20394d1866cd
Cr-Commit-Position: refs/heads/master@{#392275}

[hta - Chromium, 2016-05-08 11:45:33]

hta@chromium.org changed reviewers:
+ hta@chromium.org

[hta - Chromium, 2016-05-08 11:45:34]

Post-commit comment - suggest adding a comment.

(at a higher level, I actually like this default better. The whole thing is
somewhat hacky, in my opinion.)

https://codereview.chromium.org/1956023003/diff/20001/content/renderer/media/...
File content/renderer/media/user_media_client_impl_unittest.cc (right):

https://codereview.chromium.org/1956023003/diff/20001/content/renderer/media/...
content/renderer/media/user_media_client_impl_unittest.cc:626: // If audio is
requested, but no constraint, it should be true.
can you add a comment here as to why it's currently expecting FALSE, with a
crbug.com/<number> link?