Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 1967963002: CPDF_VariableText::GetIterator() never returns NULL. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

CPDF_VariableText::GetIterator() never returns NULL. Same goes for CFX_Edit::GetIterator(). Committed: https://pdfium.googlesource.com/pdfium/+/821d59e1d66b67af970c59b7681828b1b82858b6

Patch Set 1 : Remove if statements, unique_ptr #

Patch Set 2 : Early returns #

Patch Set 3 : std::unique_ptr, typos #

Patch Set 4 : CFX_Edit::GetIterator() never returns NULL either #

Patch Set 5 : Fix more nits in CFX_Edit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1124 lines, -1199 lines) Patch
M core/fpdfdoc/cpdf_variabletext.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M core/fpdfdoc/cpvt_generateap.cpp View 1 chunk +58 lines, -61 lines 0 comments Download
M core/fpdfdoc/include/cpdf_variabletext.h View 2 chunks +3 lines, -1 line 0 comments Download
M fpdfsdk/fxedit/fxet_ap.cpp View 1 2 3 2 chunks +78 lines, -80 lines 0 comments Download
M fpdfsdk/fxedit/fxet_edit.cpp View 1 2 3 4 19 chunks +606 lines, -661 lines 0 comments Download
M fpdfsdk/fxedit/fxet_pageobjs.cpp View 1 2 3 6 chunks +298 lines, -309 lines 0 comments Download
M fpdfsdk/fxedit/include/fxet_edit.h View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Edit.cpp View 1 2 3 2 chunks +42 lines, -45 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_EditCtrl.cpp View 1 2 3 3 chunks +32 lines, -35 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Lei Zhang
Patch set 1 and 2 are a bit hard to read, but it's mostly just ...
4 years, 7 months ago (2016-05-11 04:27:41 UTC) #3
Wei Li
lgtm
4 years, 7 months ago (2016-05-11 17:14:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1967963002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1967963002/80001
4 years, 7 months ago (2016-05-11 19:59:07 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 19:59:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/821d59e1d66b67af970c59b7681828b1b828...

Powered by Google App Engine
This is Rietveld 408576698