core/fpdfdoc/include/cpdf_variabletext.h - Issue 1967963002: CPDF_VariableText::GetIterator() never returns NULL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfdoc/include/cpdf_variabletext.h

Issue 1967963002: CPDF_VariableText::GetIterator() never returns NULL. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Fix more nits in CFX_Edit Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfdoc/include/cpdf_variabletext.h

diff --git a/core/fpdfdoc/include/cpdf_variabletext.h b/core/fpdfdoc/include/cpdf_variabletext.h

index a14ad52752e92bd50a0dac5a832ce242d13a81cf..c9184bc7c065726106cfaeb040273048f187a680 100644

--- a/core/fpdfdoc/include/cpdf_variabletext.h

+++ b/core/fpdfdoc/include/cpdf_variabletext.h

@@ -7,6 +7,8 @@

#ifndef CORE_FPDFDOC_INCLUDE_CPDF_VARIABLETEXT_H_

#define CORE_FPDFDOC_INCLUDE_CPDF_VARIABLETEXT_H_

+#include <memory>

#include "core/fpdfdoc/cpvt_floatrect.h"

#include "core/fpdfdoc/cpvt_lineinfo.h"

#include "core/fpdfdoc/include/cpvt_line.h"

@@ -246,7 +248,7 @@ class CPDF_VariableText : private CPDF_EditContainer {

FX_BOOL m_bInitial;

FX_BOOL m_bRichText;

CPDF_VariableText::Provider* m_pVTProvider;

- CPDF_VariableText::Iterator* m_pVTIterator;

+ std::unique_ptr<CPDF_VariableText::Iterator> m_pVTIterator;

};

#endif // CORE_FPDFDOC_INCLUDE_CPDF_VARIABLETEXT_H_

« no previous file with comments | « core/fpdfdoc/cpvt_generateap.cpp ('k') | fpdfsdk/fxedit/fxet_ap.cpp » ('j') | no next file with comments »