Ignore MediaController in the video fullscreen button logic

Ignore MediaController in the video fullscreen button logic

There were three problems:

 1. When fullScreenEnabled() was false, HTMLMediaElement's
    enterFullscreen() was used as a fallback, but that function checks
    the setting and does nothing. This has been the case since cleanup
    from April 2013, r149489: https://codereview.chromium.org/14670004

 2. MediaController's hasVideo() returned true if any of the slave
    elements had video, which could show the button for a video element
    with no video.

 3. The fullscreen button didn't do anything for slaved media elements.

The added tests verify that (1) no fullscreen button is shown when the
fullscreen feature is disabled or (2) when there is no video track, and
(3) that clicking the fullscreen button actually enters fullscreen.

BUG=351661
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169429

[adamk, 2014-03-14 23:45:22]

I'd feel more comfortable leaving this for acolwell's return (which I believe
should be on Monday based on his OOO message).

[philipj_slow, 2014-03-15 02:36:12]

On 2014/03/14 23:45:22, adamk wrote:
> I'd feel more comfortable leaving this for acolwell's return (which I believe
> should be on Monday based on his OOO message).

No problem!

[acolwell GONE FROM CHROMIUM, 2014-03-17 23:57:55]

lgtm

https://codereview.chromium.org/196793021/diff/20001/LayoutTests/media/video-...
File LayoutTests/media/video-controls-fullscreen.js (right):

https://codereview.chromium.org/196793021/diff/20001/LayoutTests/media/video-...
LayoutTests/media/video-controls-fullscreen.js:37: t.done();
nit: early return here since the test is supposed to be done at this point?

https://codereview.chromium.org/196793021/diff/20001/LayoutTests/media/video-...
LayoutTests/media/video-controls-fullscreen.js:44:
v1.addEventListener("webkitfullscreenchange", t.step_func(function()
Why are we waiting for prefixed events?

[philipj_slow, 2014-03-18 03:08:02]

https://codereview.chromium.org/196793021/diff/20001/LayoutTests/media/video-...
File LayoutTests/media/video-controls-fullscreen.js (right):

https://codereview.chromium.org/196793021/diff/20001/LayoutTests/media/video-...
LayoutTests/media/video-controls-fullscreen.js:37: t.done();
On 2014/03/17 23:57:55, acolwell wrote:
> nit: early return here since the test is supposed to be done at this point?

Ah, yes. testharness.js actually ignores anything that happens after t.done(),
but this could make it look like the following assertion still matters. I'll
move that to the top as well so that it's actually run.

https://codereview.chromium.org/196793021/diff/20001/LayoutTests/media/video-...
LayoutTests/media/video-controls-fullscreen.js:44:
v1.addEventListener("webkitfullscreenchange", t.step_func(function()
On 2014/03/17 23:57:55, acolwell wrote:
> Why are we waiting for prefixed events?

The fullscreen API is still not unprefixed, so the prefixed event is the only
one we fire :(

[philipj_slow, 2014-03-18 07:16:53]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2014-03-18 07:17:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/196793021/60001

[commit-bot: I haz the power, 2014-03-18 07:20:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-18 07:20:28]

Try jobs failed on following builders:
  tryserver.blink on blink_presubmit

[philipj_slow, 2014-03-18 07:40:29]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2014-03-18 07:40:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/196793021/60001

[commit-bot: I haz the power, 2014-03-18 08:29:22]

Change committed as 169429