Issue 14670004: Remove scaffolding for WebKit-proprietary fullscreen API

Issue 14670004: Remove scaffolding for WebKit-proprietary fullscreen API (Closed)

Created:
7 years, 7 months ago by adamk

Modified:
7 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
blink-reviews, feature-media-reviews_chromium.org, vcarbune.chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove scaffolding for WebKit-proprietary fullscreen API Chromium/Blink use a different fullscreen API, and never supported the WebKit version. This removes a few remaining bits of code that used to implement it. R=darin Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149489

Patch Set 1 #

Patch Set 2 : Workaround trybots #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -193 lines)			Patch
D	LayoutTests/media/media-fullscreen.js	View	1 chunk	+0 lines, -127 lines	0 comments	Download
M	Source/WebKit/chromium/src/ChromeClientImpl.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/WebKit/chromium/src/ChromeClientImpl.cpp	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	Source/core/dom/EventNames.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/core/html/HTMLAttributeNames.in	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/html/HTMLMediaElement.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLMediaElement.cpp	View	5 chunks	+4 lines, -42 lines	0 comments	Download
M	Source/core/page/ChromeClient.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/core/page/DOMWindow.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/14670004/1

7 years, 7 months ago (2013-04-30 22:33:40 UTC) #3

commit-bot: I haz the power

Retried try job too often on mac_layout_rel for step(s) webkit_lint, webkit_tests, webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=3932

7 years, 7 months ago (2013-04-30 22:41:21 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/14670004/4002

7 years, 7 months ago (2013-04-30 22:44:02 UTC) #5

Message was sent while issue was closed.

Change committed as 149489

Expand Messages | Collapse Messages