Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 14670004: Remove scaffolding for WebKit-proprietary fullscreen API (Closed)

Created:
7 years, 7 months ago by adamk
Modified:
7 years, 7 months ago
CC:
blink-reviews, feature-media-reviews_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

Remove scaffolding for WebKit-proprietary fullscreen API Chromium/Blink use a different fullscreen API, and never supported the WebKit version. This removes a few remaining bits of code that used to implement it. R=darin Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149489

Patch Set 1 #

Patch Set 2 : Workaround trybots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -193 lines) Patch
D LayoutTests/media/media-fullscreen.js View 1 chunk +0 lines, -127 lines 0 comments Download
M Source/WebKit/chromium/src/ChromeClientImpl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/WebKit/chromium/src/ChromeClientImpl.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/dom/EventNames.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLAttributeNames.in View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLMediaElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 5 chunks +4 lines, -42 lines 0 comments Download
M Source/core/page/ChromeClient.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/page/DOMWindow.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
adamk
7 years, 7 months ago (2013-04-30 20:31:19 UTC) #1
darin (slow to review)
LGTM
7 years, 7 months ago (2013-04-30 22:32:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/14670004/1
7 years, 7 months ago (2013-04-30 22:33:40 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_lint, webkit_tests, webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=3932
7 years, 7 months ago (2013-04-30 22:41:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/14670004/4002
7 years, 7 months ago (2013-04-30 22:44:02 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-04-30 23:43:31 UTC) #6
Message was sent while issue was closed.
Change committed as 149489

Powered by Google App Engine
This is Rietveld 408576698