Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7397)

Unified Diff: chrome/browser/ui/webui/settings/people_handler.h

Issue 1967883002: Settings People Revamp: Fix some small bugs in the handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/people_handler.h
diff --git a/chrome/browser/ui/webui/settings/people_handler.h b/chrome/browser/ui/webui/settings/people_handler.h
index 1ca63972498cc54f934d8d97b8c4eb7f09a89cf7..e09b145d64724753d60b85700ff4c65f8b692c01 100644
--- a/chrome/browser/ui/webui/settings/people_handler.h
+++ b/chrome/browser/ui/webui/settings/people_handler.h
@@ -112,11 +112,6 @@ class PeopleHandler : public SettingsPageUIHandler,
// sync_driver::SyncServiceObserver implementation.
void OnStateChanged() override;
- // Shows advanced configuration dialog without going through sign in dialog.
- // Kicks the sync backend if necessary with showing spinner dialog until it
- // gets ready.
- void OpenConfigureSync();
-
// Returns a newly created dictionary with a number of properties that
// correspond to the status of sync.
std::unique_ptr<base::DictionaryValue> GetSyncStatusDictionary();
@@ -200,7 +195,8 @@ class PeopleHandler : public SettingsPageUIHandler,
// Used to listen for pref changes to allow or disallow signin.
PrefChangeRegistrar profile_pref_registrar_;
- // Manages observer lifetime.
+ // Manages observer lifetimes.
+ ScopedObserver<SigninManagerBase, PeopleHandler> signin_observer_;
ScopedObserver<ProfileSyncService, PeopleHandler> sync_service_observer_;
DISALLOW_COPY_AND_ASSIGN(PeopleHandler);

Powered by Google App Engine
This is Rietveld 408576698