Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Side by Side Diff: chrome/browser/ui/webui/settings/people_handler.h

Issue 1967883002: Settings People Revamp: Fix some small bugs in the handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_SETTINGS_PEOPLE_HANDLER_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_SETTINGS_PEOPLE_HANDLER_H_
6 #define CHROME_BROWSER_UI_WEBUI_SETTINGS_PEOPLE_HANDLER_H_ 6 #define CHROME_BROWSER_UI_WEBUI_SETTINGS_PEOPLE_HANDLER_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/gtest_prod_util.h" 10 #include "base/gtest_prod_util.h"
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 // SigninManagerBase::Observer implementation. 105 // SigninManagerBase::Observer implementation.
106 void GoogleSigninSucceeded(const std::string& account_id, 106 void GoogleSigninSucceeded(const std::string& account_id,
107 const std::string& username, 107 const std::string& username,
108 const std::string& password) override; 108 const std::string& password) override;
109 void GoogleSignedOut(const std::string& account_id, 109 void GoogleSignedOut(const std::string& account_id,
110 const std::string& username) override; 110 const std::string& username) override;
111 111
112 // sync_driver::SyncServiceObserver implementation. 112 // sync_driver::SyncServiceObserver implementation.
113 void OnStateChanged() override; 113 void OnStateChanged() override;
114 114
115 // Shows advanced configuration dialog without going through sign in dialog.
116 // Kicks the sync backend if necessary with showing spinner dialog until it
117 // gets ready.
118 void OpenConfigureSync();
119
120 // Returns a newly created dictionary with a number of properties that 115 // Returns a newly created dictionary with a number of properties that
121 // correspond to the status of sync. 116 // correspond to the status of sync.
122 std::unique_ptr<base::DictionaryValue> GetSyncStatusDictionary(); 117 std::unique_ptr<base::DictionaryValue> GetSyncStatusDictionary();
123 118
124 // Helper routine that gets the ProfileSyncService associated with the parent 119 // Helper routine that gets the ProfileSyncService associated with the parent
125 // profile. 120 // profile.
126 ProfileSyncService* GetSyncService() const; 121 ProfileSyncService* GetSyncService() const;
127 122
128 // Returns the LoginUIService for the parent profile. 123 // Returns the LoginUIService for the parent profile.
129 LoginUIService* GetLoginUIService() const; 124 LoginUIService* GetLoginUIService() const;
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 // histograms in the case that the user cancels out. 188 // histograms in the case that the user cancels out.
194 bool configuring_sync_; 189 bool configuring_sync_;
195 190
196 // The OneShotTimer object used to timeout of starting the sync backend 191 // The OneShotTimer object used to timeout of starting the sync backend
197 // service. 192 // service.
198 std::unique_ptr<base::OneShotTimer> backend_start_timer_; 193 std::unique_ptr<base::OneShotTimer> backend_start_timer_;
199 194
200 // Used to listen for pref changes to allow or disallow signin. 195 // Used to listen for pref changes to allow or disallow signin.
201 PrefChangeRegistrar profile_pref_registrar_; 196 PrefChangeRegistrar profile_pref_registrar_;
202 197
203 // Manages observer lifetime. 198 // Manages observer lifetimes.
199 ScopedObserver<SigninManagerBase, PeopleHandler> signin_observer_;
204 ScopedObserver<ProfileSyncService, PeopleHandler> sync_service_observer_; 200 ScopedObserver<ProfileSyncService, PeopleHandler> sync_service_observer_;
205 201
206 DISALLOW_COPY_AND_ASSIGN(PeopleHandler); 202 DISALLOW_COPY_AND_ASSIGN(PeopleHandler);
207 }; 203 };
208 204
209 } // namespace settings 205 } // namespace settings
210 206
211 #endif // CHROME_BROWSER_UI_WEBUI_SETTINGS_PEOPLE_HANDLER_H_ 207 #endif // CHROME_BROWSER_UI_WEBUI_SETTINGS_PEOPLE_HANDLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698