Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 19678002: Remove more dead code in applyProperty(CSSPropertyFont) (Closed)

Created:
7 years, 5 months ago by eseidel
Modified:
7 years, 5 months ago
CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, darktears
Visibility:
Public.

Description

Remove more dead code in applyProperty(CSSPropertyFont) The FontValue handling code has been dead since http://trac.webkit.org/changeset/100273 If this code were not dead, it would be exercised by the fast/canvas/crash-set-font.html test added by jchaffraix in http://trac.webkit.org/changeset/96122 BUG=237268 R=dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154428

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -28 lines) Patch
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +9 lines, -28 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
7 years, 5 months ago (2013-07-17 20:29:55 UTC) #1
dglazkov
lgtm
7 years, 5 months ago (2013-07-17 20:34:14 UTC) #2
eseidel
7 years, 5 months ago (2013-07-17 20:56:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r154428 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698