Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1967773005: update dart:math (Closed)

Created:
4 years, 7 months ago by Harry Terkelsen
Modified:
4 years, 7 months ago
Reviewers:
Bob Nystrom, sra1
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2361 lines, -47 lines) Patch
M karma.conf.js View 1 chunk +1 line, -0 lines 0 comments Download
M lib/runtime/dart_sdk.js View 6 chunks +94 lines, -9 lines 0 comments Download
M test/browser/language_tests.js View 1 chunk +11 lines, -0 lines 0 comments Download
A test/codegen/lib/math/coin_test.dart View 1 chunk +62 lines, -0 lines 0 comments Download
A test/codegen/lib/math/double_pow_test.dart View 1 chunk +162 lines, -0 lines 0 comments Download
A test/codegen/lib/math/low_test.dart View 1 chunk +34 lines, -0 lines 0 comments Download
A test/codegen/lib/math/math2_test.dart View 1 chunk +265 lines, -0 lines 0 comments Download
A test/codegen/lib/math/math_parse_double_test.dart View 1 chunk +169 lines, -0 lines 0 comments Download
A test/codegen/lib/math/math_test.dart View 1 chunk +254 lines, -0 lines 0 comments Download
A test/codegen/lib/math/min_max_test.dart View 1 chunk +580 lines, -0 lines 0 comments Download
A test/codegen/lib/math/pi_test.dart View 1 chunk +56 lines, -0 lines 0 comments Download
A test/codegen/lib/math/point_test.dart View 1 chunk +90 lines, -0 lines 0 comments Download
A test/codegen/lib/math/random_big_test.dart View 1 chunk +22 lines, -0 lines 0 comments Download
A test/codegen/lib/math/random_secure_test.dart View 1 chunk +62 lines, -0 lines 0 comments Download
A test/codegen/lib/math/random_test.dart View 1 chunk +101 lines, -0 lines 0 comments Download
A test/codegen/lib/math/rectangle_test.dart View 1 chunk +250 lines, -0 lines 0 comments Download
M test/codegen_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tool/input_sdk/lib/math/math.dart View 7 chunks +16 lines, -8 lines 0 comments Download
M tool/input_sdk/lib/math/point.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tool/input_sdk/lib/math/random.dart View 1 chunk +20 lines, -7 lines 0 comments Download
M tool/input_sdk/lib/math/rectangle.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M tool/input_sdk/patch/math_patch.dart View 3 chunks +102 lines, -10 lines 0 comments Download
M tool/sdk_expected_errors.txt View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Harry Terkelsen
4 years, 7 months ago (2016-05-11 21:34:56 UTC) #2
Bob Nystrom
lgtm
4 years, 7 months ago (2016-05-11 23:34:48 UTC) #3
Harry Terkelsen
4 years, 7 months ago (2016-05-12 16:03:17 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
e159fadcdcfbcf5c3039e750f567ce72da2ef512 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698