Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1967743005: remove canonicalType (Closed)

Created:
4 years, 7 months ago by Jennifer Messerly
Modified:
4 years, 7 months ago
Reviewers:
Leaf, sra1
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

remove canonicalType it is unused now since the extension type system replaced it. there's a potentially interesting use case supported, e.g. ES6 subclasses of JS Array, but we can ignore that for now (IMO) R=sra@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/256de552f91ca50f9c0bfb9315687341be26ecf8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -35 lines) Patch
M lib/runtime/dart_sdk.js View 3 chunks +0 lines, -13 lines 0 comments Download
M tool/input_sdk/private/ddc_runtime/types.dart View 3 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Jennifer Messerly
As we were just talking about :)
4 years, 7 months ago (2016-05-11 17:51:21 UTC) #4
sra1
lgtm
4 years, 7 months ago (2016-05-11 17:53:40 UTC) #5
Jennifer Messerly
4 years, 7 months ago (2016-05-11 17:57:03 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
256de552f91ca50f9c0bfb9315687341be26ecf8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698