Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: lib/runtime/dart_sdk.js

Issue 1967743005: remove canonicalType (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | tool/input_sdk/private/ddc_runtime/types.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart_sdk.js
diff --git a/lib/runtime/dart_sdk.js b/lib/runtime/dart_sdk.js
index 9a5d0a71252a4e3c9d53335ac9ceb34444e7916b..2f6e0b2dcbbb9c7ec39516747dea9f935ebb0c48 100644
--- a/lib/runtime/dart_sdk.js
+++ b/lib/runtime/dart_sdk.js
@@ -798,15 +798,6 @@ dart_library.library('dart_sdk', null, /* Imports */[
if (!dart._isSubtype(ret1, ret2, covariant)) return null;
return true;
};
- dart.canonicalType = function(t) {
- if (t === Object) return Object;
- if (t === Function) return Function;
- if (t === Array) return List;
- if (t === String) return String;
- if (t === Number) return double;
- if (t === Boolean) return bool;
- return t;
- };
dart._subtypeMemo = function(f) {
let memo = new Map();
return (t1, t2) => {
@@ -830,8 +821,6 @@ dart_library.library('dart_sdk', null, /* Imports */[
return type == core.Object || type == dart.dynamic;
};
dart._isSubtype = function(t1, t2, covariant) {
- t1 = dart.canonicalType(t1);
- t2 = dart.canonicalType(t2);
if (t1 === t2) return true;
if (dart._isTop(t2) || dart._isBottom(t1)) {
return true;
@@ -853,8 +842,6 @@ dart_library.library('dart_sdk', null, /* Imports */[
return false;
};
dart.isClassSubType = function(t1, t2, covariant) {
- t1 = dart.canonicalType(t1);
- dart.assert(t2 == dart.canonicalType(t2));
if (t1 == t2) return true;
if (t1 == core.Object) return false;
if (t1 == null) return t2 == core.Object || t2 == dart.dynamic;
« no previous file with comments | « no previous file | tool/input_sdk/private/ddc_runtime/types.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698