Issue 19677: Clean up the Windows-ness in the sizing of new views. Write a bunch of commen...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19677: Clean up the Windows-ness in the sizing of new views. Write a bunch of commen... (Closed)

Created:
11 years, 10 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Clean up the Windows-ness in the sizing of new views. Write a bunch of comments about issues I discovered in this process. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8923

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -33 lines)			Patch
M	chrome/browser/renderer_host/render_widget_host_view.h	View		1 chunk	+12 lines, -13 lines	0 comments	Download
M	chrome/browser/tab_contents/web_contents.cc	View	1	2 chunks	+10 lines, -13 lines	0 comments	Download
M	chrome/browser/tab_contents/web_contents_view.h	View		2 chunks	+3 lines, -5 lines	0 comments	Download
M	chrome/browser/tab_contents/web_contents_view_win.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/tab_contents/web_contents_view_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

LGTM