chrome/browser/tab_contents/web_contents_view.h - Issue 19677: Clean up the Windows-ness in the sizing of new views. Write a bunch of commen...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/web_contents_view.h

Issue 19677: Clean up the Windows-ness in the sizing of new views. Write a bunch of commen... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/tab_contents/web_contents_view.h

===================================================================

--- chrome/browser/tab_contents/web_contents_view.h (revision 8895)

+++ chrome/browser/tab_contents/web_contents_view.h (working copy)

@@ -18,7 +18,6 @@

class RenderViewHost;

class RenderWidgetHost;

class RenderWidgetHostView;

-class RenderWidgetHostViewWin; // TODO(brettw) this should not be necessary.

class WebContents;

struct WebDropData;

class WebKeyboardEvent;

@@ -43,10 +42,9 @@

virtual void CreateView() = 0;

// Sets up the View that holds the rendered web page, receives messages for

- // it and contains page plugins.

- // TODO(brettw) make this so we don't need to return the Win version (see the

- // caller in WebContents).

- virtual RenderWidgetHostViewWin* CreateViewForWidget(

+ // it and contains page plugins. The host view should be sized to the current

+ // size of the WebContents.

+ virtual RenderWidgetHostView* CreateViewForWidget(

RenderWidgetHost* render_widget_host) = 0;

// Returns the native widget that contains the contents of the tab.

« no previous file with comments | « chrome/browser/tab_contents/web_contents.cc ('k') | chrome/browser/tab_contents/web_contents_view_win.h » ('j') | no next file with comments »