Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 1967663005: [MD settings] remove extraneous item-icon attributes (Closed)

Created:
4 years, 7 months ago by dschuyler
Modified:
4 years, 7 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] remove extraneous item-icon attributes This CL cleans up some old item-icon attributes on the side nav menu items. BUG=593989 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f2092cc4a8d305eeb385c53a850e00178d836e8f Cr-Commit-Position: refs/heads/master@{#392799}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M chrome/browser/resources/settings/settings_menu/settings_menu.html View 2 chunks +18 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
dschuyler
4 years, 7 months ago (2016-05-11 00:14:56 UTC) #3
dpapad
lgtm
4 years, 7 months ago (2016-05-11 00:40:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1967663005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1967663005/1
4 years, 7 months ago (2016-05-11 00:48:46 UTC) #7
michaelpg
On 2016/05/11 00:48:46, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 7 months ago (2016-05-11 01:03:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 01:04:22 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 01:05:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2092cc4a8d305eeb385c53a850e00178d836e8f
Cr-Commit-Position: refs/heads/master@{#392799}

Powered by Google App Engine
This is Rietveld 408576698