Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2959)

Unified Diff: chrome/browser/resources/settings/settings_menu/settings_menu.html

Issue 1967663005: [MD settings] remove extraneous item-icon attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_menu/settings_menu.html
diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.html b/chrome/browser/resources/settings/settings_menu/settings_menu.html
index 965227f0e91aecd0f6737520a23d7b4ada0ae79c..583f05ea1b7ebee2ca333855320035cbea6b13a6 100644
--- a/chrome/browser/resources/settings/settings_menu/settings_menu.html
+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.html
@@ -81,42 +81,42 @@
<paper-submenu data-page="basic" id="basicPage" opened="{{basicOpened_}}">
<div class="menu-trigger" data-section="" on-tap="openPage_">
<span i18n-content="basicPageTitle"></span>
- <iron-icon icon="[[arrowState_(basicOpened_)]]" item-icon></iron-icon>
+ <iron-icon icon="[[arrowState_(basicOpened_)]]"></iron-icon>
</div>
<paper-menu attr-for-selected="data-section" class="menu-content"
data-page="basic" id="basicMenu">
<if expr="chromeos">
<div data-section="internet" on-tap="openPage_">
- <iron-icon icon="device:network-wifi" item-icon></iron-icon>
+ <iron-icon icon="device:network-wifi"></iron-icon>
<span i18n-content="internetPageTitle"></span>
</div>
</if>
<div data-section="people" on-tap="openPage_">
- <iron-icon icon="social:people" item-icon></iron-icon>
+ <iron-icon icon="social:people"></iron-icon>
<span i18n-content="peoplePageTitle"></span>
</div>
<div data-section="appearance" on-tap="openPage_">
- <iron-icon icon="image:palette" item-icon></iron-icon>
+ <iron-icon icon="image:palette"></iron-icon>
<span i18n-content="appearancePageTitle"></span>
</div>
<if expr="chromeos">
<div data-section="device" on-tap="openPage_">
- <iron-icon icon="hardware:laptop-chromebook" item-icon></iron-icon>
+ <iron-icon icon="hardware:laptop-chromebook"></iron-icon>
<span i18n-content="devicePageTitle"></span>
</div>
</if>
<div data-section="search" on-tap="openPage_">
- <iron-icon icon="cr:search" item-icon></iron-icon>
+ <iron-icon icon="cr:search"></iron-icon>
<span i18n-content="searchPageTitle"></span>
</div>
<if expr="not chromeos">
<div data-section="defaultBrowser" on-tap="openPage_">
- <iron-icon icon="av:web" item-icon></iron-icon>
+ <iron-icon icon="av:web"></iron-icon>
<span i18n-content="defaultBrowser"></span>
</div>
</if>
<div data-section="onStartup" on-tap="openPage_">
- <iron-icon icon="icons:power-settings-new" item-icon></iron-icon>
+ <iron-icon icon="icons:power-settings-new"></iron-icon>
<span i18n-content="onStartup"></span>
</div>
</paper-menu>
@@ -125,51 +125,51 @@
opened="{{advancedOpened_}}">
<div class="menu-trigger" data-section="" on-tap="openPage_">
<span i18n-content="advancedPageTitle"></span>
- <iron-icon icon="[[arrowState_(advancedOpened_)]]" item-icon>
+ <iron-icon icon="[[arrowState_(advancedOpened_)]]">
</iron-icon>
</div>
<paper-menu attr-for-selected="data-section" class="menu-content"
data-page="advanced" id="advancedMenu">
<if expr="chromeos">
<div data-section="dateTime" on-tap="openPage_">
- <iron-icon icon="device:access-time" item-icon></iron-icon>
+ <iron-icon icon="device:access-time"></iron-icon>
<span i18n-content="dateTimePageTitle"></span>
</div>
</if>
<div data-section="privacy" on-tap="openPage_">
- <iron-icon icon="hardware:security" item-icon></iron-icon>
+ <iron-icon icon="hardware:security"></iron-icon>
<span i18n-content="privacyPageTitle"></span>
</div>
<if expr="chromeos">
<div data-section="bluetooth" on-tap="openPage_">
- <iron-icon icon="device:bluetooth" item-icon></iron-icon>
+ <iron-icon icon="device:bluetooth"></iron-icon>
<span i18n-content="bluetoothPageTitle"></span>
</div>
</if>
<div data-section="passwordsAndForms" on-tap="openPage_">
- <iron-icon icon="icons:assignment" item-icon></iron-icon>
+ <iron-icon icon="icons:assignment"></iron-icon>
<span i18n-content="passwordsAndAutofillPageTitle"></span>
</div>
<div data-section="languages" on-tap="openPage_">
- <iron-icon icon="icons:language" item-icon></iron-icon>
+ <iron-icon icon="icons:language"></iron-icon>
<span i18n-content="languagesPageTitle"></span>
</div>
<div data-section="downloads" on-tap="openPage_">
- <iron-icon icon="icons:file-download" item-icon></iron-icon>
+ <iron-icon icon="icons:file-download"></iron-icon>
<span i18n-content="downloadsPageTitle"></span>
</div>
<div data-section="a11y" on-tap="openPage_">
- <iron-icon icon="icons:accessibility" item-icon></iron-icon>
+ <iron-icon icon="icons:accessibility"></iron-icon>
<span i18n-content="a11yPageTitle"></span>
</div>
<if expr="not chromeos">
<div data-section="system" on-tap="openPage_">
- <iron-icon icon="icons:build" item-icon></iron-icon>
+ <iron-icon icon="icons:build"></iron-icon>
<span i18n-content="systemPageTitle"></span>
</div>
</if>
<div data-section="reset" on-tap="openPage_">
- <iron-icon icon="icons:restore" item-icon></iron-icon>
+ <iron-icon icon="icons:restore"></iron-icon>
<span i18n-content="resetPageTitle"></span>
</div>
</paper-menu>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698