Always check that a Name is a String before converting it.

Always check that a Name is a String before converting it.

BUG=608662
R=haraken@chromium.org

Committed: https://crrev.com/544ea1e08ba0f678208e3c468aa576358ab542fb
Cr-Commit-Position: refs/heads/master@{#392567}

[haraken, 2016-05-10 08:08:54]

LGTM

[jochen (gone - plz use gerrit), 2016-05-10 08:10:47]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2016-05-10 08:10:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1967453002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1967453002/1

[commit-bot: I haz the power, 2016-05-10 08:50:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-10 08:51:15]

Description was changed from

==========
Always check that a Name is a String before converting it.

BUG=608662
R=haraken@chromium.org
==========

to

==========
Always check that a Name is a String before converting it.

BUG=608662
R=haraken@chromium.org

Committed: https://crrev.com/544ea1e08ba0f678208e3c468aa576358ab542fb
Cr-Commit-Position: refs/heads/master@{#392567}
==========

[commit-bot: I haz the power, 2016-05-10 08:51:16]

Patchset 1 (id:??) landed as
https://crrev.com/544ea1e08ba0f678208e3c468aa576358ab542fb
Cr-Commit-Position: refs/heads/master@{#392567}

[esprehn, 2016-05-11 23:45:27]

Can we code generate this into namedPropertyGetterCallback instead? Also can we
get a test?

[Yuki, 2016-05-18 08:58:52]

On 2016/05/11 23:45:27, esprehn wrote:
> Can we code generate this into namedPropertyGetterCallback instead? Also can
we
> get a test?

I'm preparing a CL to code generate it into namedPropertyXxxCallback
at http://crrev.com/1993593003 .

I don't understand why non-Strings are passed to the callback, nor a test case.

The binding layer specifies v8::PropertyHandlerFlags::kOnlyInterceptStrings, so
non-Strings (e.g. Symbol) should not be passed to the binding callbacks. 
Weird...  jochen@, what do you think?

[haraken, 2016-05-18 09:00:37]

On 2016/05/18 08:58:52, Yuki wrote:
> On 2016/05/11 23:45:27, esprehn wrote:
> > Can we code generate this into namedPropertyGetterCallback instead? Also can
> we
> > get a test?
> 
> I'm preparing a CL to code generate it into namedPropertyXxxCallback
> at http://crrev.com/1993593003 .
> 
> I don't understand why non-Strings are passed to the callback, nor a test
case.
> 
> The binding layer specifies v8::PropertyHandlerFlags::kOnlyInterceptStrings,
so
> non-Strings (e.g. Symbol) should not be passed to the binding callbacks. 
> Weird...  jochen@, what do you think?

FWIW, jochen is OOO for two weeks.

[Yuki, 2016-05-18 09:02:20]

On 2016/05/18 09:00:37, haraken wrote:
> On 2016/05/18 08:58:52, Yuki wrote:
> > On 2016/05/11 23:45:27, esprehn wrote:
> > > Can we code generate this into namedPropertyGetterCallback instead? Also
can
> > we
> > > get a test?
> > 
> > I'm preparing a CL to code generate it into namedPropertyXxxCallback
> > at http://crrev.com/1993593003 .
> > 
> > I don't understand why non-Strings are passed to the callback, nor a test
> case.
> > 
> > The binding layer specifies v8::PropertyHandlerFlags::kOnlyInterceptStrings,
> so
> > non-Strings (e.g. Symbol) should not be passed to the binding callbacks. 
> > Weird...  jochen@, what do you think?
> 
> FWIW, jochen is OOO for two weeks.

I'm okay to wait for two weeks.  This is not urgent.