Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1967433002: [Merge-M51][Downloads/History] Add tab-url and tab-referrer-url to DownloadRow (Closed)

Created:
4 years, 7 months ago by asanka
Modified:
4 years, 7 months ago
Reviewers:
svaldez, jam, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

[Merge-M51][Downloads/History] Add tab-url and tab-referrer-url to DownloadRow Also add a README.md file to components/test/data/history explaining how to generate a history.NN.sql file. R=sky@chromium.org, jam@chromium.org, svaldez@chromium.org BUG=602403 Review URL: https://codereview.chromium.org/1875033005 Cr-Commit-Position: refs/heads/master@{#387169} (cherry picked from commit 038d58d3b114c6bd1d9712f78c23eefb50b9b3d4) Committed: https://chromium.googlesource.com/chromium/src/+/77a7f22877f83aca6844991cfb17db3edd6f0947

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -275 lines) Patch
M chrome/browser/download/download_history.cc View 2 chunks +11 lines, -31 lines 0 comments Download
M chrome/browser/download/download_history_unittest.cc View 5 chunks +22 lines, -34 lines 0 comments Download
M chrome/browser/download/download_ui_controller_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M components/history/core/browser/download_database.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/history/core/browser/download_database.cc View 6 chunks +17 lines, -5 lines 0 comments Download
M components/history/core/browser/download_row.h View 2 chunks +11 lines, -1 line 0 comments Download
M components/history/core/browser/download_row.cc View 3 chunks +16 lines, -21 lines 0 comments Download
M components/history/core/browser/history_backend_db_unittest.cc View 5 chunks +101 lines, -90 lines 0 comments Download
M components/history/core/browser/history_database.cc View 2 chunks +10 lines, -1 line 0 comments Download
M components/history/core/test/history_backend_db_base_test.cc View 1 chunk +9 lines, -22 lines 0 comments Download
A components/test/data/history/README.md View 1 chunk +25 lines, -0 lines 0 comments Download
A + components/test/data/history/history.30.sql View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/download/download_browsertest.cc View 6 chunks +12 lines, -0 lines 0 comments Download
M content/browser/download/download_item_factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/download/download_item_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/download/download_item_impl.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/download/download_manager_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/download/download_manager_impl.cc View 4 chunks +13 lines, -41 lines 0 comments Download
M content/browser/download/download_manager_impl_unittest.cc View 4 chunks +8 lines, -0 lines 0 comments Download
M content/public/browser/download_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/test/mock_download_manager.h View 3 chunks +6 lines, -0 lines 0 comments Download
M content/public/test/mock_download_manager.cc View 6 chunks +15 lines, -20 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
asanka
4 years, 7 months ago (2016-05-10 01:56:45 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
77a7f22877f83aca6844991cfb17db3edd6f0947.

Powered by Google App Engine
This is Rietveld 408576698