[Downloads/History] Add tab-url and tab-referrer-url to DownloadRow

[Downloads/History] Add tab-url and tab-referrer-url to DownloadRow

Also add a README.md file to components/test/data/history explaining how
to generate a history.NN.sql file.

R=sky@chromium.org, jam@chromium.org, svaldez@chromium.org
BUG=602403
Committed: https://crrev.com/038d58d3b114c6bd1d9712f78c23eefb50b9b3d4
Cr-Commit-Position: refs/heads/master@{#387169}

[asanka, 2016-04-11 19:36:30]

Description was changed from

==========
[Downloads/History] Add tab-url and tab-referrer-url to DownloadRow

R=sky@chromium.org
BUG=
==========

to

==========
[Downloads/History] Add tab-url and tab-referrer-url to DownloadRow

R=sky@chromium.org
BUG=602403
==========

[sky, 2016-04-11 21:04:13]

LGTM

https://codereview.chromium.org/1875033005/diff/1/components/history/core/bro...
File components/history/core/browser/history_backend_db_unittest.cc (right):

https://codereview.chromium.org/1875033005/diff/1/components/history/core/bro...
components/history/core/browser/history_backend_db_unittest.cc:646: // current
version, creating the mime_type abd original_mime_type columns.
Update this comment.

[asanka, 2016-04-12 19:47:26]

Description was changed from

==========
[Downloads/History] Add tab-url and tab-referrer-url to DownloadRow

R=sky@chromium.org
BUG=602403
==========

to

==========
[Downloads/History] Add tab-url and tab-referrer-url to DownloadRow

R=sky@chromium.org, jam@chromium.org, svaldez@chromium.org
BUG=602403
==========

[asanka, 2016-04-12 19:47:26]

asanka@chromium.org changed reviewers:
+ jam@chromium.org, svaldez@chromium.org

[asanka, 2016-04-12 19:49:59]

sky: Thanks!

jam: Could you take a look at content/public/ ?

svaldez: Could you take a look at {chrome,content}/browser/download ?

https://codereview.chromium.org/1875033005/diff/1/components/history/core/bro...
File components/history/core/browser/history_backend_db_unittest.cc (right):

https://codereview.chromium.org/1875033005/diff/1/components/history/core/bro...
components/history/core/browser/history_backend_db_unittest.cc:646: // current
version, creating the mime_type abd original_mime_type columns.
On 2016/04/11 at 21:04:12, sky wrote:
> Update this comment.

Done.

[svaldez, 2016-04-12 20:54:17]

lgtm, would be nice if there was a way to keep the separated formatting for all
the constructors which is easier to read.

https://codereview.chromium.org/1875033005/diff/40001/components/history/core...
File components/history/core/browser/download_row.h (left):

https://codereview.chromium.org/1875033005/diff/40001/components/history/core...
components/history/core/browser/download_row.h:28: const GURL& referrer,
While here, could you rename this to referrer_url to match the class variable
and other ones.

https://codereview.chromium.org/1875033005/diff/40001/components/test/data/hi...
File components/test/data/history/README.md (right):

https://codereview.chromium.org/1875033005/diff/40001/components/test/data/hi...
components/test/data/history/README.md:1: ## How to generate history.N.sql files
using a Chromium build.
Add a note about the README in the CL description.

[asanka, 2016-04-13 19:05:47]

Description was changed from

==========
[Downloads/History] Add tab-url and tab-referrer-url to DownloadRow

R=sky@chromium.org, jam@chromium.org, svaldez@chromium.org
BUG=602403
==========

to

==========
[Downloads/History] Add tab-url and tab-referrer-url to DownloadRow

Also add a README.md file to components/test/data/history explaining how to
generate a history.NN.sql file.

R=sky@chromium.org, jam@chromium.org, svaldez@chromium.org
BUG=602403
==========

[asanka, 2016-04-13 19:06:01]

Description was changed from

==========
[Downloads/History] Add tab-url and tab-referrer-url to DownloadRow

Also add a README.md file to components/test/data/history explaining how to
generate a history.NN.sql file.

R=sky@chromium.org, jam@chromium.org, svaldez@chromium.org
BUG=602403
==========

to

==========
[Downloads/History] Add tab-url and tab-referrer-url to DownloadRow

Also add a README.md file to components/test/data/history explaining how
to generate a history.NN.sql file.

R=sky@chromium.org, jam@chromium.org, svaldez@chromium.org
BUG=602403
==========

[jam, 2016-04-13 21:15:00]

lgtm

[asanka, 2016-04-13 23:21:38]

The CQ bit was checked by asanka@chromium.org

[asanka, 2016-04-13 23:21:39]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
svaldez@chromium.org
Link to the patchset: https://codereview.chromium.org/1875033005/#ps100001
(title: "Update expectations for DownloadUIController test.")

[commit-bot: I haz the power, 2016-04-13 23:22:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1875033005/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1875033005/100001

[commit-bot: I haz the power, 2016-04-14 00:29:41]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-04-14 00:31:23]

Description was changed from

==========
[Downloads/History] Add tab-url and tab-referrer-url to DownloadRow

Also add a README.md file to components/test/data/history explaining how
to generate a history.NN.sql file.

R=sky@chromium.org, jam@chromium.org, svaldez@chromium.org
BUG=602403
==========

to

==========
[Downloads/History] Add tab-url and tab-referrer-url to DownloadRow

Also add a README.md file to components/test/data/history explaining how
to generate a history.NN.sql file.

R=sky@chromium.org, jam@chromium.org, svaldez@chromium.org
BUG=602403

Committed: https://crrev.com/038d58d3b114c6bd1d9712f78c23eefb50b9b3d4
Cr-Commit-Position: refs/heads/master@{#387169}
==========

[commit-bot: I haz the power, 2016-04-14 00:31:24]

Patchset 6 (id:??) landed as
https://crrev.com/038d58d3b114c6bd1d9712f78c23eefb50b9b3d4
Cr-Commit-Position: refs/heads/master@{#387169}