Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1967363004: Disable page_cycler.morejs. (Closed)

Created:
4 years, 7 months ago by dtu
Modified:
4 years, 7 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable page_cycler.morejs. This is the last remaining benchmark that depends on src-internal, and we're going to deprecate it. I'd like to clean up that gclient config. TBR=kouhei BUG=606277, 611484 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Committed: https://crrev.com/c62d2bd321645e5054b86de8fb0509d846420b86 Cr-Commit-Position: refs/heads/master@{#393442}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/perf/benchmarks/page_cycler.py View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 13 (7 generated)
dtu
4 years, 7 months ago (2016-05-12 23:34:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1967363004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1967363004/1
4 years, 7 months ago (2016-05-12 23:35:11 UTC) #6
kouhei (in TOK)
lgtm
4 years, 7 months ago (2016-05-13 01:39:40 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 03:39:51 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c62d2bd321645e5054b86de8fb0509d846420b86 Cr-Commit-Position: refs/heads/master@{#393442}
4 years, 7 months ago (2016-05-13 03:41:54 UTC) #11
nednguyen
4 years, 7 months ago (2016-05-13 03:44:05 UTC) #13
Message was sent while issue was closed.
https://codereview.chromium.org/1967363004/diff/1/tools/perf/benchmarks/page_...
File tools/perf/benchmarks/page_cycler.py (right):

https://codereview.chromium.org/1967363004/diff/1/tools/perf/benchmarks/page_...
tools/perf/benchmarks/page_cycler.py:118: @benchmark.Disabled('all') #
crbug.com/606277 crbug.com/611484
Err, why not just remove this entirely & MoreJsPageSet? :-)

Powered by Google App Engine
This is Rietveld 408576698