Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: tools/perf/benchmarks/page_cycler.py

Issue 1967363004: Disable page_cycler.morejs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from core import perf_benchmark 5 from core import perf_benchmark
6 6
7 from measurements import page_cycler 7 from measurements import page_cycler
8 import page_sets 8 import page_sets
9 from telemetry import benchmark 9 from telemetry import benchmark
10 10
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 108
109 @classmethod 109 @classmethod
110 def ShouldDisable(cls, possible_browser): 110 def ShouldDisable(cls, possible_browser):
111 # http://crbug.com/597656 (Android Nexus 5X). 111 # http://crbug.com/597656 (Android Nexus 5X).
112 # http://crbug.com/605543 (Mac Snow Leopard). 112 # http://crbug.com/605543 (Mac Snow Leopard).
113 return (possible_browser.browser_type == 'reference' and ( 113 return (possible_browser.browser_type == 'reference' and (
114 possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X' or 114 possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X' or
115 possible_browser.platform.GetOSVersionName() == 'snowleopard')) 115 possible_browser.platform.GetOSVersionName() == 'snowleopard'))
116 116
117 117
118 @benchmark.Disabled('all') # crbug.com/606277 crbug.com/611484
nednguyen 2016/05/13 03:44:05 Err, why not just remove this entirely & MoreJsPag
118 class PageCyclerMorejs(_PageCycler): 119 class PageCyclerMorejs(_PageCycler):
119 """Page load for a variety of pages that were JavaScript heavy in 2009.""" 120 """Page load for a variety of pages that were JavaScript heavy in 2009."""
120 page_set = page_sets.MorejsPageSet 121 page_set = page_sets.MorejsPageSet
121 122
122 @classmethod 123 @classmethod
123 def Name(cls): 124 def Name(cls):
124 return 'page_cycler.morejs' 125 return 'page_cycler.morejs'
125 126
126 127
127 # This is an old page set, we intend to remove it after more modern benchmarks 128 # This is an old page set, we intend to remove it after more modern benchmarks
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 return cls.IsSvelte(possible_browser) # http://crbug.com/607657 229 return cls.IsSvelte(possible_browser) # http://crbug.com/607657
229 230
230 231
231 @benchmark.Disabled('all') # crbug.com/443730 232 @benchmark.Disabled('all') # crbug.com/443730
232 class PageCyclerBigJs(_PageCycler): 233 class PageCyclerBigJs(_PageCycler):
233 page_set = page_sets.BigJsPageSet 234 page_set = page_sets.BigJsPageSet
234 235
235 @classmethod 236 @classmethod
236 def Name(cls): 237 def Name(cls):
237 return 'page_cycler.big_js' 238 return 'page_cycler.big_js'
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698