Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 19673003: [NaCl SDK] Consistent use of copyright header. (Closed)

Created:
7 years, 5 months ago by Sam Clegg
Modified:
7 years, 5 months ago
Reviewers:
noelallen1, binji
CC:
chromium-reviews, binji
Visibility:
Public.

Description

[NaCl SDK] Consistent use of copyright header. Use C++ style copyright header in all C++ headers and sources. Use consistent C-style copyright header in C sources and headers. R=noelallen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213024

Patch Set 1 #

Total comments: 20

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+310 lines, -374 lines) Patch
M native_client_sdk/src/examples/api/graphics_3d/graphics_3d.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/examples/api/graphics_3d/matrix.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/error_handling/error_handling.c View 2 chunks +3 lines, -6 lines 0 comments Download
M native_client_sdk/src/libraries/error_handling/string_stream.c View 2 chunks +3 lines, -5 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/error.h View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/inode_pool.h View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/ioctl.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_handle.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_handle.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_intercept.h View 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_intercept.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_object.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_object.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_proxy.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_wrap.h View 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_wrap_glibc.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_wrap_newlib.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_wrap_real.h View 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_wrap_win.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_dev.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_dev.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_factory.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_html5fs.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_html5fs.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_http.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_http.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_mem.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_mem.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_node.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_node.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_node_dir.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_node_dir.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_node_html5fs.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_node_html5fs.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_node_http.h View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_node_http.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_node_mem.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_node_mem.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_passthrough.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_passthrough.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/nacl_io.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/nacl_io.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/osdirent.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/osinttypes.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/osmman.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/osstat.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/ostypes.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/osunistd.h View 1 2 chunks +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/osutime.h View 1 2 chunks +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/path.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/path.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/pepper/all_interfaces.h View 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/pepper/define_empty_macros.h View 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/pepper/undef_macros.h View 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/pepper_interface.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/pepper_interface.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/real_pepper_interface.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/real_pepper_interface.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/typed_mount_factory.h View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/kernel_object_test.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/kernel_proxy_mock.h View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/kernel_proxy_mock.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/kernel_proxy_test.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/kernel_wrap_test.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/mock_util.h View 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/mount_html5fs_test.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/mount_http_test.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/mount_mock.h View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/mount_mock.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/mount_node_mock.h View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/mount_node_mock.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/mount_node_test.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/mount_test.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/path_test.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/pepper_interface_mock.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/pepper_interface_mock.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/ppapi_simple/ps.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/ppapi_simple/ps_event.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/ppapi_simple/ps_main.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/sdk_util/atomicops.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M native_client_sdk/src/libraries/sdk_util/auto_lock.h View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M native_client_sdk/src/libraries/sdk_util/macros.h View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
M native_client_sdk/src/libraries/sdk_util/ref_object.h View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/sdk_util/scoped_ref.h View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/sdk_util/simple_lock.h View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M native_client_sdk/src/libraries/xray/browser.c View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
M native_client_sdk/src/libraries/xray/demangle.c View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M native_client_sdk/src/libraries/xray/hashtable.c View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M native_client_sdk/src/libraries/xray/parsesymbols.c View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M native_client_sdk/src/libraries/xray/report.c View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M native_client_sdk/src/libraries/xray/stringpool.c View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M native_client_sdk/src/libraries/xray/symtable.c View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M native_client_sdk/src/libraries/xray/xray.h View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M native_client_sdk/src/libraries/xray/xray.c View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M native_client_sdk/src/libraries/xray/xray.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/xray/xray.odt View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
M native_client_sdk/src/libraries/xray/xray_priv.h View 1 2 3 4 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Sam Clegg
7 years, 5 months ago (2013-07-19 21:03:46 UTC) #1
noelallen1
C -> Definitely included by C C? I think it's included by C otherwise LGTM ...
7 years, 5 months ago (2013-07-19 21:56:37 UTC) #2
Sam Clegg
https://codereview.chromium.org/19673003/diff/1/native_client_sdk/src/libraries/nacl_io/ioctl.h File native_client_sdk/src/libraries/nacl_io/ioctl.h (right): https://codereview.chromium.org/19673003/diff/1/native_client_sdk/src/libraries/nacl_io/ioctl.h#newcode1 native_client_sdk/src/libraries/nacl_io/ioctl.h:1: // Copyright 2013 The Chromium Authors. All rights reserved. ...
7 years, 5 months ago (2013-07-22 18:15:50 UTC) #3
noelallen1
One typo otherwise LGTM https://codereview.chromium.org/19673003/diff/13001/native_client_sdk/src/libraries/nacl_io/mount_mem.cc File native_client_sdk/src/libraries/nacl_io/mount_mem.cc (right): https://codereview.chromium.org/19673003/diff/13001/native_client_sdk/src/libraries/nacl_io/mount_mem.cc#newcode1 native_client_sdk/src/libraries/nacl_io/mount_mem.cc:1: // Copyright (c) 2012 The ...
7 years, 5 months ago (2013-07-22 18:33:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/19673003/24001
7 years, 5 months ago (2013-07-22 22:38:20 UTC) #5
commit-bot: I haz the power
Failed to apply patch for native_client_sdk/src/libraries/xray/xray.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 5 months ago (2013-07-22 22:38:44 UTC) #6
Sam Clegg
7 years, 5 months ago (2013-07-23 01:22:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 manually as r213024 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698