Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1967233002: Enable disk writes closer to where strict mode violation occurs in NotificationPlatformBridge (Closed)

Created:
4 years, 7 months ago by pkotwicz
Modified:
4 years, 7 months ago
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable disk writes closer to where strict mode violation occurs in NotificationPlatformBridge WebAPKs will use CustomNotificationBuilder. This CL will avoid duplicating the code to enable/disable disk writes for all users of CustomNotificationBuilder BUG=609122 Committed: https://crrev.com/32e39d5b1fe5da844d5f9a4f7b6a4621d629c51e Cr-Commit-Position: refs/heads/master@{#393303}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -18 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java View 3 chunks +19 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java View 1 3 chunks +1 line, -14 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilderTest.java View 1 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
pkotwicz
Peter, can you please take a look? What testing do I need to do to ...
4 years, 7 months ago (2016-05-11 19:06:44 UTC) #2
Peter Wen
On 2016/05/11 19:06:44, pkotwicz wrote: > Peter, can you please take a look? > > ...
4 years, 7 months ago (2016-05-12 14:09:36 UTC) #3
pkotwicz
Peter Beverloo for OWNERS
4 years, 7 months ago (2016-05-12 14:14:58 UTC) #5
Peter Beverloo
lgtm
4 years, 7 months ago (2016-05-12 14:28:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1967233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1967233002/1
4 years, 7 months ago (2016-05-12 15:22:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1967233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1967233002/20001
4 years, 7 months ago (2016-05-12 17:24:05 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-12 18:09:42 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 18:11:36 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/32e39d5b1fe5da844d5f9a4f7b6a4621d629c51e
Cr-Commit-Position: refs/heads/master@{#393303}

Powered by Google App Engine
This is Rietveld 408576698