Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1681)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java

Issue 1967233002: Enable disk writes closer to where strict mode violation occurs in NotificationPlatformBridge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java
index 8b9312600ae3f3dae6b373f8990b008637090361..ea0de6251f943f980700d173fd1c2b984344843e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java
@@ -14,8 +14,6 @@ import android.graphics.Bitmap;
import android.net.Uri;
import android.os.Build;
import android.os.Bundle;
-import android.os.StrictMode;
-import android.os.SystemClock;
import android.text.Spannable;
import android.text.SpannableStringBuilder;
import android.text.TextUtils;
@@ -42,7 +40,6 @@ import org.chromium.chrome.browser.widget.RoundedIconGenerator;
import java.net.URI;
import java.net.URISyntaxException;
-import java.util.concurrent.TimeUnit;
import javax.annotation.Nullable;
@@ -528,17 +525,7 @@ public class NotificationPlatformBridge {
}
String platformTag = makePlatformTag(persistentNotificationId, origin, tag);
- // Temporarily allowing disk access. TODO: Fix. See http://crbug.com/577185
- StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskReads();
- StrictMode.allowThreadDiskWrites();
- try {
- long time = SystemClock.elapsedRealtime();
- mNotificationManager.notify(platformTag, PLATFORM_ID, notificationBuilder.build());
- RecordHistogram.recordTimesHistogram("Android.StrictMode.NotificationUIBuildTime",
- SystemClock.elapsedRealtime() - time, TimeUnit.MILLISECONDS);
- } finally {
- StrictMode.setThreadPolicy(oldPolicy);
- }
+ mNotificationManager.notify(platformTag, PLATFORM_ID, notificationBuilder.build());
}
private NotificationBuilderBase createNotificationBuilder() {

Powered by Google App Engine
This is Rietveld 408576698