Issue 196723009: Not submitted - Fixing invalid visibility states with layers which showed up in unittests ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196723009: Not submitted - Fixing invalid visibility states with layers which showed up in unittests ... (Closed)

Created:
6 years, 9 months ago by Mr4D (OOO till 08-26)

Modified:
6 years, 8 months ago

Reviewers:

CC:
chromium-reviews, kalyank, ben+aura_chromium.org, sadrul, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixing invalid visibility states with layers which showed up in unittests (opacity==0, visibility==true) When fixing an animation problem yesterday, I added a DCHECK to test for an invalid layer state. In that state, the layer's alpha is 0 while the layers visibility is true. Several function will fail if this condition is present. As an example: Window::Show / Window::Hide. After adding the DCHECK several unit tests failed and this patch is addressing this problem. BUG=351553 TEST=unittests

Patch Set 1 #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -12 lines)			Patch
M	ash/wm/overview/window_overview.cc	View	4 chunks	+8 lines, -3 lines	1 comment	Download
M	ash/wm/overview/window_selector_panels.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	ash/wm/panels/panel_layout_manager.cc	View	5 chunks	+10 lines, -5 lines	0 comments	Download
M	ash/wm/system_modal_container_layout_manager.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	ui/aura/window.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

flackr

Isn't this just working around the problem? I.e. if we want what is effectively 0 ...

6 years, 9 months ago (2014-03-12 19:12:20 UTC) #2

sky

6 years, 9 months ago (2014-03-12 19:31:39 UTC) #3

https://codereview.chromium.org/196723009/diff/1/ash/wm/overview/window_overv...
File ash/wm/overview/window_overview.cc (right):

https://codereview.chromium.org/196723009/diff/1/ash/wm/overview/window_overv...
ash/wm/overview/window_overview.cc:55: const float kWindowLayerNotShown =
0.001f;
Ugh. Why can't you actually hide here and evervy where?

Expand Messages | Collapse Messages