Not submitted - Fixing invalid visibility states with layers which showed up in unittests ...

ash/wm/system_modal_container_layout_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/system_modal_container_layout_manager.h"
 
 #include "ash/session_state_delegate.h"
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
 #include "ash/wm/system_modal_container_event_filter.h"
@@ skipping 142 matching lines @@
     params.bounds = Shell::GetScreen()->GetDisplayNearestWindow(
         container_).bounds();
     modal_background_->Init(params);
     modal_background_->GetNativeView()->SetName(
         "SystemModalContainerLayoutManager.ModalBackground");
     views::View* contents_view = new views::View();
     // TODO(jamescook): This could be SK_ColorWHITE for the new dialog style.
     contents_view->set_background(
         views::Background::CreateSolidBackground(SK_ColorBLACK));
     modal_background_->SetContentsView(contents_view);
-    modal_background_->GetNativeView()->layer()->SetOpacity(0.0f);
+    // The layer should at the beginning be invisible and fade then in. Since
+    // the visibility is true an opacity of 0.0 would be illegal and Show()
+    // will complaint, we have to start with a slightly bigger value.
+    modal_background_->GetNativeView()->layer()->SetOpacity(0.001f);
   }
 
   ui::ScopedLayerAnimationSettings settings(
       modal_background_->GetNativeView()->layer()->GetAnimator());
   modal_background_->Show();
   modal_background_->GetNativeView()->layer()->SetOpacity(0.5f);
   container_->StackChildAtTop(modal_background_->GetNativeView());
 }
 
 void SystemModalContainerLayoutManager::DestroyModalBackground() {
@@ skipping 41 matching lines @@
 void SystemModalContainerLayoutManager::RemoveModalWindow(
     aura::Window* window) {
   aura::Window::Windows::iterator it =
       std::find(modal_windows_.begin(), modal_windows_.end(), window);
   if (it != modal_windows_.end())
     modal_windows_.erase(it);
 }
 
 }  // namespace internal
 }  // namespace ash