migrate skpdiff to tools

migrate skpdiff to tools

R=djsollen@google.com

Committed: https://code.google.com/p/skia/source/detail?r=10225

[Zach Reizner, 2013-07-17 19:41:06]

I've made some gyp changes and it would be nice to get an opinion from the gyp
sensei to minimize breakages.

[djsollen, 2013-07-17 19:47:09]

https://codereview.chromium.org/19671002/diff/1/gyp/tools.gyp
File gyp/tools.gyp (right):

https://codereview.chromium.org/19671002/diff/1/gyp/tools.gyp#newcode398
gyp/tools.gyp:398: 'targets': [
this doesn't need to be in it's own target list just make it part of the
previous one.

https://codereview.chromium.org/19671002/diff/1/gyp/tools.gyp#newcode403
gyp/tools.gyp:403: '../tools/skpdiff/main.cpp',
to make it easier to search for can we call it skpdiff_main.cpp?

https://codereview.chromium.org/19671002/diff/1/gyp/tools.gyp#newcode430
gyp/tools.gyp:430: }, {
}, { # !skia_opencl

https://codereview.chromium.org/19671002/diff/1/tools/skpdiff/skpdiff.gyp
File tools/skpdiff/skpdiff.gyp (right):

https://codereview.chromium.org/19671002/diff/1/tools/skpdiff/skpdiff.gyp#new...
tools/skpdiff/skpdiff.gyp:1: # GYP file to build skpdiff.
we shouldn't need this file anymore.

[Zach Reizner, 2013-07-17 19:56:17]

https://codereview.chromium.org/19671002/diff/1/gyp/tools.gyp
File gyp/tools.gyp (right):

https://codereview.chromium.org/19671002/diff/1/gyp/tools.gyp#newcode398
gyp/tools.gyp:398: 'targets': [
On 2013/07/17 19:47:10, djsollen wrote:
> this doesn't need to be in it's own target list just make it part of the
> previous one.

for now I wanted to prevent it from building on windows because it uses some
posix only functionality and I have yet to try to compile it with MSVC.

[djsollen, 2013-07-17 20:01:24]

Ok.  We will get you a window laptop to test on so that you can remove that
restriction.

[djsollen, 2013-07-19 19:11:44]

https://codereview.chromium.org/19671002/diff/17001/tools/skpdiff/SkPMetric.cpp
File tools/skpdiff/SkPMetric.cpp (right):

https://codereview.chromium.org/19671002/diff/17001/tools/skpdiff/SkPMetric.c...
tools/skpdiff/SkPMetric.cpp:267: int smallerDimension = width < height ? width :
height;
should be spaces not tabs.

https://codereview.chromium.org/19671002/diff/17001/tools/skpdiff/skpdiff_uti...
File tools/skpdiff/skpdiff_util.cpp (right):

https://codereview.chromium.org/19671002/diff/17001/tools/skpdiff/skpdiff_uti...
tools/skpdiff/skpdiff_util.cpp:77: #if defined(_POSIX_TIMERS) &&
defined(CLOCK_REALTIME)
put a TODO here about refactoring BenchTimer so that it can be used here.

https://codereview.chromium.org/19671002/diff/17001/tools/skpdiff/skpdiff_uti...
tools/skpdiff/skpdiff_util.cpp:96: // Open the directory and check for success
spaces not tabs

https://codereview.chromium.org/19671002/diff/17001/tools/skpdiff/skpdiff_uti...
tools/skpdiff/skpdiff_util.cpp:120: char pathLength = strlen(path);
spacing seems way off here.

[djsollen, 2013-07-19 19:35:11]

lgtm

[Zach Reizner, 2013-07-22 13:14:17]

Committed patchset #6 manually as r10225 (presubmit successful).