Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1967073002: Check closure data for serialization (Closed)

Created:
4 years, 7 months ago by Johnni Winther
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fixes #

Patch Set 3 : Fix ConstructorBodyElementX.resolvedAst #

Total comments: 2

Patch Set 4 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+365 lines, -132 lines) Patch
M pkg/compiler/lib/src/closure.dart View 4 chunks +38 lines, -30 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 2 2 chunks +19 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 1 3 chunks +14 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/keys.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 2 chunks +5 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 2 chunks +10 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/serialization/compilation_test.dart View 1 3 chunks +9 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/serialization/equivalence_test.dart View 1 4 chunks +6 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/serialization/helper.dart View 1 14 chunks +34 lines, -48 lines 0 comments Download
M tests/compiler/dart2js/serialization/model_test.dart View 1 2 3 10 chunks +201 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/serialization/resolved_ast_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_helper.dart View 1 2 3 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 7 months ago (2016-05-11 14:17:00 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1967073002/diff/40001/tests/compiler/dart2js/serialization/test_helper.dart File tests/compiler/dart2js/serialization/test_helper.dart (right): https://codereview.chromium.org/1967073002/diff/40001/tests/compiler/dart2js/serialization/test_helper.dart#newcode167 tests/compiler/dart2js/serialization/test_helper.dart:167: void onSameElement(a, b)}) { consistent with the comments ...
4 years, 7 months ago (2016-05-11 23:55:24 UTC) #3
Johnni Winther
Committed patchset #4 (id:60001) manually as cb2fcd8117eb4844c04c429c35fb018fa2c05737 (presubmit successful).
4 years, 7 months ago (2016-05-12 07:59:11 UTC) #5
Johnni Winther
4 years, 7 months ago (2016-05-12 10:47:44 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1967073002/diff/40001/tests/compiler/dart2js/...
File tests/compiler/dart2js/serialization/test_helper.dart (right):

https://codereview.chromium.org/1967073002/diff/40001/tests/compiler/dart2js/...
tests/compiler/dart2js/serialization/test_helper.dart:167: void onSameElement(a,
b)}) {
On 2016/05/11 23:55:24, Siggi Cherem (dart-lang) wrote:
> consistent with the comments from other CLs, maybe rename this as
> `checkElement`?

Done.

Powered by Google App Engine
This is Rietveld 408576698