Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: tests/compiler/dart2js/serialization/equivalence_test.dart

Issue 1967073002: Check closure data for serialization (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comments. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/serialization/equivalence_test.dart
diff --git a/tests/compiler/dart2js/serialization/equivalence_test.dart b/tests/compiler/dart2js/serialization/equivalence_test.dart
index 32a538af0f4532270bb5af6704554991cdfc2cd6..8c1c96c8dfd00170b630917535a7e311c37a0395 100644
--- a/tests/compiler/dart2js/serialization/equivalence_test.dart
+++ b/tests/compiler/dart2js/serialization/equivalence_test.dart
@@ -245,6 +245,12 @@ class ElementPropertyEquivalence extends BaseElementVisitor<dynamic, Element> {
element1.accept(this, element2);
check(element1, element2, 'isSynthesized',
element1.isSynthesized, element2.isSynthesized);
+ check(element1, element2, 'isLocal',
+ element1.isLocal, element2.isLocal);
+ check(element1, element2, 'isFinal',
+ element1.isFinal, element2.isFinal);
+ check(element1, element2, 'isConst',
+ element1.isConst, element2.isConst);
}
@override
@@ -438,10 +444,6 @@ class ElementPropertyEquivalence extends BaseElementVisitor<dynamic, Element> {
checkTypes(
element1, element2, 'type',
element1.type, element2.type);
- check(element1, element2, 'isConst',
- element1.isConst, element2.isConst);
- check(element1, element2, 'isFinal',
- element1.isFinal, element2.isFinal);
checkConstants(
element1, element2, 'constant',
element1.constant, element2.constant);
@@ -553,8 +555,6 @@ class ElementPropertyEquivalence extends BaseElementVisitor<dynamic, Element> {
checkTypes(
element1, element2, 'type',
element1.type, element2.type);
- check(element1, element2, 'isConst',
- element1.isConst, element2.isConst);
check(element1, element2, 'isExternal',
element1.isExternal, element2.isExternal);
if (element1.isConst && !element1.isExternal) {
@@ -646,9 +646,6 @@ class ElementPropertyEquivalence extends BaseElementVisitor<dynamic, Element> {
check(
element1, element2, 'isNamed',
element1.isNamed, element2.isNamed);
- check(
- element1, element2, 'isFinal',
- element1.isFinal, element2.isFinal);
check(element1, element2, 'name', element1.name, element2.name);
if (element1.isOptional) {
checkConstants(
« no previous file with comments | « tests/compiler/dart2js/serialization/compilation_test.dart ('k') | tests/compiler/dart2js/serialization/helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698