Clean up obsolete LayoutUnit.rawValue() FIXME comments.

Clean up obsolete LayoutUnit.rawValue() FIXME comments.

One comment references altering enclosingIntRect() to do pixel snapping, but
we've made many pixel snapping changes since that comment was written, so
without an explicit open bug or known broken test case removal seems reasonable.

BUG=612055
Committed: https://crrev.com/afc18e1ee0f60d03916954684c8e77d57606fe17
Cr-Commit-Position: refs/heads/master@{#394275}

[wkorman, 2016-05-10 22:08:46]

wkorman@chromium.org changed reviewers:
+ chrishtr@chromium.org, eae@chromium.org

[eae, 2016-05-10 22:30:11]

https://codereview.chromium.org/1966913002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp (right):

https://codereview.chromium.org/1966913002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp:84: return
LayoutRect(enclosingIntRect(logicalFrameRect()));
This should probably be pixelSnappedIntRect instead or possibly just return the
underlying logicalFrameRect.

[leviw_travelin_and_unemployed, 2016-05-11 00:49:22]

leviw@chromium.org changed reviewers:
+ leviw@chromium.org

[leviw_travelin_and_unemployed, 2016-05-11 00:49:25]

https://codereview.chromium.org/1966913002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp (right):

https://codereview.chromium.org/1966913002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp:83: if
(knownToHaveNoOverflow() || !gTextBoxesWithOverflow) {
And remove those braces! :)

[wkorman, 2016-05-15 21:39:00]

Description was changed from

==========
Clean up obsolete LayoutUnit.rawValue() FIXME comments.

One comment references altering enclosingIntRect() to do pixel snapping, but
we've made many pixel snapping changes since that comment was written, so
without an explicit open bug or known broken test case removal seems reasonable.
==========

to

==========
Clean up obsolete LayoutUnit.rawValue() FIXME comments.

One comment references altering enclosingIntRect() to do pixel snapping, but
we've made many pixel snapping changes since that comment was written, so
without an explicit open bug or known broken test case removal seems reasonable.

BUG=612055
==========

[wkorman, 2016-05-15 22:01:04]

https://codereview.chromium.org/1966913002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp (right):

https://codereview.chromium.org/1966913002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp:84: return
LayoutRect(enclosingIntRect(logicalFrameRect()));
On 2016/05/10 at 22:30:11, eae wrote:
> This should probably be pixelSnappedIntRect instead or possibly just return
the underlying logicalFrameRect.

Updated to return logicalFrameRect() directly. A small number of repaint tests
affected, see the trybot results for patchset 2 on this change. They look
reasonable to me.

https://codereview.chromium.org/1966913002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp (right):

https://codereview.chromium.org/1966913002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp:83: if
(knownToHaveNoOverflow() || !gTextBoxesWithOverflow) {
On 2016/05/11 at 00:49:24, leviw_travelin_and_unemployed wrote:
> And remove those braces! :)

Done.

[wkorman, 2016-05-15 22:01:13]

The CQ bit was checked by wkorman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-15 22:01:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1966913002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1966913002/40001

[commit-bot: I haz the power, 2016-05-15 23:44:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-15 23:44:07]

Dry run: This issue passed the CQ dry run.

[eae, 2016-05-16 16:49:34]

LGTM

[wkorman, 2016-05-17 21:28:54]

The CQ bit was checked by wkorman@chromium.org

[wkorman, 2016-05-17 21:28:54]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1966913002/#ps60001
(title: "Sync to head.")

[commit-bot: I haz the power, 2016-05-17 21:29:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1966913002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1966913002/60001

[commit-bot: I haz the power, 2016-05-18 00:03:51]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-18 00:06:29]

Description was changed from

==========
Clean up obsolete LayoutUnit.rawValue() FIXME comments.

One comment references altering enclosingIntRect() to do pixel snapping, but
we've made many pixel snapping changes since that comment was written, so
without an explicit open bug or known broken test case removal seems reasonable.

BUG=612055
==========

to

==========
Clean up obsolete LayoutUnit.rawValue() FIXME comments.

One comment references altering enclosingIntRect() to do pixel snapping, but
we've made many pixel snapping changes since that comment was written, so
without an explicit open bug or known broken test case removal seems reasonable.

BUG=612055

Committed: https://crrev.com/afc18e1ee0f60d03916954684c8e77d57606fe17
Cr-Commit-Position: refs/heads/master@{#394275}
==========

[commit-bot: I haz the power, 2016-05-18 00:06:31]

Patchset 4 (id:??) landed as
https://crrev.com/afc18e1ee0f60d03916954684c8e77d57606fe17
Cr-Commit-Position: refs/heads/master@{#394275}