Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp

Issue 1966913002: Clean up obsolete LayoutUnit.rawValue() FIXME comments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Sync to head. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp b/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp
index 35033c3c017158144ac11b6eacc661878d7c7e0c..545ff16437845baf0a629e9156cddc3959dee88e 100644
--- a/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp
+++ b/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp
@@ -80,12 +80,8 @@ void InlineTextBox::markDirty()
LayoutRect InlineTextBox::logicalOverflowRect() const
{
- if (knownToHaveNoOverflow() || !gTextBoxesWithOverflow) {
- // FIXME: the call to rawValue() below is temporary and should be removed once the transition
- // to LayoutUnit-based types is complete (crbug.com/321237). The call to enclosingIntRect()
- // should also likely be switched to LayoutUnit pixel-snapping.
- return LayoutRect(enclosingIntRect(logicalFrameRect()));
- }
+ if (knownToHaveNoOverflow() || !gTextBoxesWithOverflow)
+ return logicalFrameRect();
return gTextBoxesWithOverflow->get(this);
}
@@ -237,8 +233,6 @@ LayoutRect InlineTextBox::localSelectionRect(int startPos, int endPos) const
if (sPos || ePos != static_cast<int>(m_len)) {
r = LayoutRect(enclosingIntRect(font.selectionRectForText(textRun, FloatPoint(startingPoint), selHeight, sPos, ePos)));
} else { // Avoid computing the font width when the entire line box is selected as an optimization.
- // FIXME: the call to rawValue() below is temporary and should be removed once the transition
- // to LayoutUnit-based types is complete (crbug.com/321237)
r = LayoutRect(enclosingIntRect(LayoutRect(startingPoint, LayoutSize(m_logicalWidth, selHeight))));
}
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698