components/password_manager/core/browser/password_bubble_experiment_unittest.cc - Issue 1966903003: [Smart Lock] Make save prompt first run experience never appear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_bubble_experiment_unittest.cc

Issue 1966903003: [Smart Lock] Make save prompt first run experience never appear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/password_manager/core/browser/password_bubble_experiment_unittest.cc

diff --git a/components/password_manager/core/browser/password_bubble_experiment_unittest.cc b/components/password_manager/core/browser/password_bubble_experiment_unittest.cc

index cf2c85a671561b639cc14b0c90a30116888aab35..fd13060e111d4ac273ab79f6491a7b8bd2732cf3 100644

--- a/components/password_manager/core/browser/password_bubble_experiment_unittest.cc

+++ b/components/password_manager/core/browser/password_bubble_experiment_unittest.cc

@@ -139,7 +139,7 @@ class PasswordManagerPasswordBubbleExperimentTest : public testing::Test {

ShouldShowSavePromptFirstRunExperience(sync_service(), prefs());

if (test_case.first_run_experience ==

SavePromptFirstRunExperience::PRESENT) {

- EXPECT_TRUE(should_show_first_run_experience);

+ EXPECT_FALSE(should_show_first_run_experience);

} else {

EXPECT_FALSE(should_show_first_run_experience);

}

@@ -235,7 +235,7 @@ TEST_F(PasswordManagerPasswordBubbleExperimentTest,

{CustomPassphraseState::NONE, syncer::PASSWORDS, true,

SavePromptFirstRunExperience::NONE},

{CustomPassphraseState::NONE, syncer::PASSWORDS, false,

- SavePromptFirstRunExperience::PRESENT},

+ SavePromptFirstRunExperience::NONE},

{CustomPassphraseState::NONE, syncer::BOOKMARKS, true,

SavePromptFirstRunExperience::NONE},

{CustomPassphraseState::NONE, syncer::BOOKMARKS, false,

« no previous file with comments | « components/password_manager/core/browser/password_bubble_experiment.cc ('k') | no next file » | no next file with comments »