components/password_manager/core/browser/password_bubble_experiment.cc - Issue 1966903003: [Smart Lock] Make save prompt first run experience never appear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_bubble_experiment.cc

Issue 1966903003: [Smart Lock] Make save prompt first run experience never appear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/password_manager/core/browser/password_bubble_experiment.cc

diff --git a/components/password_manager/core/browser/password_bubble_experiment.cc b/components/password_manager/core/browser/password_bubble_experiment.cc

index 51717873430a3bd9eb7fdfde83711bac27dbb814..ab772cb4119a306d16e139972488537fa12ea14d 100644

--- a/components/password_manager/core/browser/password_bubble_experiment.cc

+++ b/components/password_manager/core/browser/password_bubble_experiment.cc

@@ -71,10 +71,7 @@ bool IsSmartLockBrandingSavePromptEnabled(

bool ShouldShowSavePromptFirstRunExperience(

const sync_driver::SyncService* sync_service,

PrefService* prefs) {

- const bool was_first_run_experience_shown = prefs->GetBoolean(

- password_manager::prefs::kWasSavePrompFirstRunExperienceShown);

- return IsSmartLockBrandingEnabled(sync_service) &&

- !was_first_run_experience_shown;

+ return false;

}

void RecordSavePromptFirstRunExperienceWasShown(PrefService* prefs) {

« no previous file with comments | « no previous file | components/password_manager/core/browser/password_bubble_experiment_unittest.cc » ('j') | no next file with comments »