Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1233)

Unified Diff: buildbot/master/skia_master_scripts/utils.py

Issue 19668009: Move gm-expected to trunk/expectations/gm , and modify scripts that use it. (Closed) Base URL: http://skia.googlecode.com/svn/
Patch Set: add_master_files Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « buildbot/master/skia_master_scripts/factory.py ('k') | buildbot/slave/skia_slave_scripts/build_step.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: buildbot/master/skia_master_scripts/utils.py
===================================================================
--- buildbot/master/skia_master_scripts/utils.py (revision 10285)
+++ buildbot/master/skia_master_scripts/utils.py (working copy)
@@ -456,16 +456,15 @@
gm_image_subdir, factory_type, extra_config=None,
perf_output_basedir=None, extra_branches=None, is_trybot=False,
**kwargs):
- """ Creates a builder and scheduler. """
+ """ Creates a builder and scheduler.
+
+ TODO(epoger): gm_image_subdir is no longer used, should be removed."""
B = helper.Builder
F = helper.Factory
if not extra_branches:
extra_branches = []
subdirs_to_checkout = set(extra_branches)
- if gm_image_subdir:
- gm_image_branch = 'gm-expected/%s' % gm_image_subdir
- subdirs_to_checkout.add(gm_image_branch)
builder_name = builder_name_schema.MakeBuilderName(
role=role,
« no previous file with comments | « buildbot/master/skia_master_scripts/factory.py ('k') | buildbot/slave/skia_slave_scripts/build_step.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698