OLD | NEW |
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 | 5 |
6 """Miscellaneous utilities needed by the Skia buildbot master.""" | 6 """Miscellaneous utilities needed by the Skia buildbot master.""" |
7 | 7 |
8 | 8 |
9 import difflib | 9 import difflib |
10 import httplib2 | 10 import httplib2 |
(...skipping 438 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
449 if skia_all_subdirs: | 449 if skia_all_subdirs: |
450 raise Exception('skia_all_subdirs has already been defined!') | 450 raise Exception('skia_all_subdirs has already been defined!') |
451 except NameError: | 451 except NameError: |
452 skia_all_subdirs = all_subdirs | 452 skia_all_subdirs = all_subdirs |
453 | 453 |
454 | 454 |
455 def _MakeBuilder(helper, role, os, model, gpu, configuration, arch, | 455 def _MakeBuilder(helper, role, os, model, gpu, configuration, arch, |
456 gm_image_subdir, factory_type, extra_config=None, | 456 gm_image_subdir, factory_type, extra_config=None, |
457 perf_output_basedir=None, extra_branches=None, is_trybot=False, | 457 perf_output_basedir=None, extra_branches=None, is_trybot=False, |
458 **kwargs): | 458 **kwargs): |
459 """ Creates a builder and scheduler. """ | 459 """ Creates a builder and scheduler. |
| 460 |
| 461 TODO(epoger): gm_image_subdir is no longer used, should be removed.""" |
460 B = helper.Builder | 462 B = helper.Builder |
461 F = helper.Factory | 463 F = helper.Factory |
462 | 464 |
463 if not extra_branches: | 465 if not extra_branches: |
464 extra_branches = [] | 466 extra_branches = [] |
465 subdirs_to_checkout = set(extra_branches) | 467 subdirs_to_checkout = set(extra_branches) |
466 if gm_image_subdir: | |
467 gm_image_branch = 'gm-expected/%s' % gm_image_subdir | |
468 subdirs_to_checkout.add(gm_image_branch) | |
469 | 468 |
470 builder_name = builder_name_schema.MakeBuilderName( | 469 builder_name = builder_name_schema.MakeBuilderName( |
471 role=role, | 470 role=role, |
472 os=os, | 471 os=os, |
473 model=model, | 472 model=model, |
474 gpu=gpu, | 473 gpu=gpu, |
475 configuration=configuration, | 474 configuration=configuration, |
476 arch=arch, | 475 arch=arch, |
477 extra_config=extra_config, | 476 extra_config=extra_config, |
478 is_trybot=is_trybot) | 477 is_trybot=is_trybot) |
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
579 # request is associated with a change but the revisions match (#5 above). | 578 # request is associated with a change but the revisions match (#5 above). |
580 if req1.source.changes and not req2.source.changes: | 579 if req1.source.changes and not req2.source.changes: |
581 return False | 580 return False |
582 if not req1.source.changes and req2.source.changes: | 581 if not req1.source.changes and req2.source.changes: |
583 return False | 582 return False |
584 if not (req1.source.changes and req2.source.changes): | 583 if not (req1.source.changes and req2.source.changes): |
585 if req1.source.revision != req2.source.revision: | 584 if req1.source.revision != req2.source.revision: |
586 return False | 585 return False |
587 | 586 |
588 return True | 587 return True |
OLD | NEW |