Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1966713002: Move nodeForHitTest() to LayoutBlockFlow. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
szager1, wkorman, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move nodeForHitTest() to LayoutBlockFlow. LayoutBlock shouldn't have to deal with continuations. BUG=302024 Committed: https://crrev.com/ac73439801af061132faf7a2652376ca244441a9 Cr-Commit-Position: refs/heads/master@{#392742}

Patch Set 1 #

Patch Set 2 : rebase master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-10 18:32:33 UTC) #2
eae
LGTM
4 years, 7 months ago (2016-05-10 18:34:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966713002/20001
4 years, 7 months ago (2016-05-10 18:37:01 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-10 22:13:03 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 22:14:09 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ac73439801af061132faf7a2652376ca244441a9
Cr-Commit-Position: refs/heads/master@{#392742}

Powered by Google App Engine
This is Rietveld 408576698