third_party/WebKit/Source/core/layout/LayoutBlock.cpp - Issue 1966713002: Move nodeForHitTest() to LayoutBlockFlow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

Issue 1966713002: Move nodeForHitTest() to LayoutBlockFlow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase master Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

index 6960260cffa7d254860dd354c1fc2db5566de71b..0177556f3e13e37f9e46fcdda965399a49a3703f 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

@@ -1481,14 +1481,6 @@ bool LayoutBlock::isPointInOverflowControl(HitTestResult& result, const LayoutPo

return layer()->getScrollableArea()->hitTestOverflowControls(result, roundedIntPoint(locationInContainer - toLayoutSize(accumulatedOffset)));

}

-Node* LayoutBlock::nodeForHitTest() const

- // If we are in the margins of block elements that are part of a

- // continuation we're actually still inside the enclosing element

- // that was split. Use the appropriate inner node.

- return isAnonymousBlockContinuation() ? continuation()->node() : node();

bool LayoutBlock::hitTestOverflowControl(HitTestResult& result, const HitTestLocation& locationInContainer, const LayoutPoint& adjustedLocation)

{

if (visibleToHitTestRequest(result.hitTestRequest())