third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.h - Issue 1966703002: Support includePartialGlyphs=false in Font::offsetForPositionForComplexText

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.h

Issue 1966703002: Support includePartialGlyphs=false in Font::offsetForPositionForComplexText (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comment as per eae review Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/TestExpectations ('K') | « third_party/WebKit/Source/platform/fonts/Font.cpp ('k') | third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.h

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.h b/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.h

index efb8c8be11587ea47850e7a5348edf980dca3686..dcab4f03d468a05e83a7b35f13233018329a6343 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.h

+++ b/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.h

@@ -52,7 +52,7 @@ public:

float width(const Font*, const TextRun&,

HashSet<const SimpleFontData*>* fallbackFonts,

FloatRect* glyphBounds);

- int offsetForPosition(const Font*, const TextRun&, float targetX);

+ int offsetForPosition(const Font*, const TextRun&, float targetX, bool includePartialGlyphs);

float fillGlyphBuffer(const Font*, const TextRun&,

HashSet<const SimpleFontData*>*, GlyphBuffer*,

unsigned from, unsigned to);