third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.cpp - Issue 1966703002: Support includePartialGlyphs=false in Font::offsetForPositionForComplexText

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.cpp

Issue 1966703002: Support includePartialGlyphs=false in Font::offsetForPositionForComplexText (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comment as per eae review Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/TestExpectations ('K') | « third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.h ('k') | third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.cpp b/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.cpp

index beef9f135bfa8b6808d8f158790e3162dd8d49ef..04d38a082bdbab31f04e79092e94c2e6d9db3cd5 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.cpp

+++ b/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.cpp

@@ -78,12 +78,12 @@ static inline float shapeResultsForRun(ShapeCache* shapeCache, const Font* font,

return totalWidth;

}

-int CachingWordShaper::offsetForPosition(const Font* font, const TextRun& run, float targetX)

+int CachingWordShaper::offsetForPosition(const Font* font, const TextRun& run, float targetX, bool includePartialGlyphs)

{

ShapeResultBuffer buffer;

shapeResultsForRun(m_shapeCache, font, run, nullptr, &buffer);

- return buffer.offsetForPosition(run, targetX);

+ return buffer.offsetForPosition(run, targetX, includePartialGlyphs);

}

float CachingWordShaper::fillGlyphBuffer(const Font* font, const TextRun& run,