Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6595)

Unified Diff: chrome/browser/extensions/extension_prefs_unittest.cc

Issue 196663003: Introduce an extension parameter which is used to customize the extension. It's available for exter… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Forgotten manifest Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_prefs_unittest.cc
diff --git a/chrome/browser/extensions/extension_prefs_unittest.cc b/chrome/browser/extensions/extension_prefs_unittest.cc
index 7d81c9f0f35a28f85304b0b3a56bd4e2a4980912..663fd17f1831f8ae4822d00405c143f34b05dee6 100644
--- a/chrome/browser/extensions/extension_prefs_unittest.cc
+++ b/chrome/browser/extensions/extension_prefs_unittest.cc
@@ -486,7 +486,8 @@ class ExtensionPrefsDelayedInstallInfo : public ExtensionPrefsTest {
Extension::ENABLED,
false,
ExtensionPrefs::DELAY_REASON_WAIT_FOR_IDLE,
- syncer::StringOrdinal());
+ syncer::StringOrdinal(),
+ std::string());
}
// Verifies that we get back expected idle install information previously
@@ -610,7 +611,8 @@ class ExtensionPrefsFinishDelayedInstallInfo : public ExtensionPrefsTest {
Extension::ENABLED,
false,
ExtensionPrefs::DELAY_REASON_WAIT_FOR_IDLE,
- syncer::StringOrdinal());
+ syncer::StringOrdinal(),
+ "Param");
// Finish idle installation
ASSERT_TRUE(prefs()->FinishDelayedInstallInfo(id_));
@@ -618,6 +620,7 @@ class ExtensionPrefsFinishDelayedInstallInfo : public ExtensionPrefsTest {
virtual void Verify() OVERRIDE {
EXPECT_FALSE(prefs()->GetDelayedInstallInfo(id_));
+ EXPECT_EQ(std::string("Param"), prefs()->GetInstallParam(id_));
const base::DictionaryValue* manifest;
ASSERT_TRUE(prefs()->ReadPrefAsDictionary(id_, "manifest", &manifest));
@@ -646,11 +649,13 @@ class ExtensionPrefsOnExtensionInstalled : public ExtensionPrefsTest {
prefs()->OnExtensionInstalled(extension_.get(),
Extension::DISABLED,
false,
- syncer::StringOrdinal());
+ syncer::StringOrdinal(),
+ "Param");
}
virtual void Verify() OVERRIDE {
EXPECT_TRUE(prefs()->IsExtensionDisabled(extension_->id()));
+ EXPECT_EQ(std::string("Param"), prefs()->GetInstallParam(extension_->id()));
}
private:
@@ -667,7 +672,8 @@ class ExtensionPrefsAppDraggedByUser : public ExtensionPrefsTest {
prefs()->OnExtensionInstalled(extension_.get(),
Extension::ENABLED,
false,
- syncer::StringOrdinal());
+ syncer::StringOrdinal(),
+ std::string());
}
virtual void Verify() OVERRIDE {

Powered by Google App Engine
This is Rietveld 408576698