Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: chrome/browser/extensions/extension_prefs_unittest.cc

Issue 196663003: Introduce an extension parameter which is used to customize the extension. It's available for exter… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Forgotten manifest Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/./extension_prefs_unittest.h" 5 #include "chrome/browser/extensions/./extension_prefs_unittest.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/files/scoped_temp_dir.h" 8 #include "base/files/scoped_temp_dir.h"
9 #include "base/path_service.h" 9 #include "base/path_service.h"
10 #include "base/prefs/mock_pref_change_callback.h" 10 #include "base/prefs/mock_pref_change_callback.h"
(...skipping 468 matching lines...) Expand 10 before | Expand all | Expand 10 after
479 prefs_.extensions_dir().AppendASCII(base::IntToString(num)); 479 prefs_.extensions_dir().AppendASCII(base::IntToString(num));
480 std::string errors; 480 std::string errors;
481 scoped_refptr<Extension> extension = Extension::Create( 481 scoped_refptr<Extension> extension = Extension::Create(
482 path, Manifest::INTERNAL, manifest, Extension::NO_FLAGS, id, &errors); 482 path, Manifest::INTERNAL, manifest, Extension::NO_FLAGS, id, &errors);
483 ASSERT_TRUE(extension.get()) << errors; 483 ASSERT_TRUE(extension.get()) << errors;
484 ASSERT_EQ(id, extension->id()); 484 ASSERT_EQ(id, extension->id());
485 prefs()->SetDelayedInstallInfo(extension.get(), 485 prefs()->SetDelayedInstallInfo(extension.get(),
486 Extension::ENABLED, 486 Extension::ENABLED,
487 false, 487 false,
488 ExtensionPrefs::DELAY_REASON_WAIT_FOR_IDLE, 488 ExtensionPrefs::DELAY_REASON_WAIT_FOR_IDLE,
489 syncer::StringOrdinal()); 489 syncer::StringOrdinal(),
490 std::string());
490 } 491 }
491 492
492 // Verifies that we get back expected idle install information previously 493 // Verifies that we get back expected idle install information previously
493 // set by SetIdleInfo. 494 // set by SetIdleInfo.
494 void VerifyIdleInfo(std::string id, int num) { 495 void VerifyIdleInfo(std::string id, int num) {
495 scoped_ptr<ExtensionInfo> info(prefs()->GetDelayedInstallInfo(id)); 496 scoped_ptr<ExtensionInfo> info(prefs()->GetDelayedInstallInfo(id));
496 ASSERT_TRUE(info); 497 ASSERT_TRUE(info);
497 std::string version; 498 std::string version;
498 ASSERT_TRUE(info->extension_manifest->GetString("version", &version)); 499 ASSERT_TRUE(info->extension_manifest->GetString("version", &version));
499 ASSERT_EQ("1." + base::IntToString(num), version); 500 ASSERT_EQ("1." + base::IntToString(num), version);
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
603 prefs_.extensions_dir().AppendASCII("test_0.2"); 604 prefs_.extensions_dir().AppendASCII("test_0.2");
604 std::string errors; 605 std::string errors;
605 scoped_refptr<Extension> new_extension = Extension::Create( 606 scoped_refptr<Extension> new_extension = Extension::Create(
606 path, Manifest::INTERNAL, manifest, Extension::NO_FLAGS, id_, &errors); 607 path, Manifest::INTERNAL, manifest, Extension::NO_FLAGS, id_, &errors);
607 ASSERT_TRUE(new_extension.get()) << errors; 608 ASSERT_TRUE(new_extension.get()) << errors;
608 ASSERT_EQ(id_, new_extension->id()); 609 ASSERT_EQ(id_, new_extension->id());
609 prefs()->SetDelayedInstallInfo(new_extension.get(), 610 prefs()->SetDelayedInstallInfo(new_extension.get(),
610 Extension::ENABLED, 611 Extension::ENABLED,
611 false, 612 false,
612 ExtensionPrefs::DELAY_REASON_WAIT_FOR_IDLE, 613 ExtensionPrefs::DELAY_REASON_WAIT_FOR_IDLE,
613 syncer::StringOrdinal()); 614 syncer::StringOrdinal(),
615 "Param");
614 616
615 // Finish idle installation 617 // Finish idle installation
616 ASSERT_TRUE(prefs()->FinishDelayedInstallInfo(id_)); 618 ASSERT_TRUE(prefs()->FinishDelayedInstallInfo(id_));
617 } 619 }
618 620
619 virtual void Verify() OVERRIDE { 621 virtual void Verify() OVERRIDE {
620 EXPECT_FALSE(prefs()->GetDelayedInstallInfo(id_)); 622 EXPECT_FALSE(prefs()->GetDelayedInstallInfo(id_));
623 EXPECT_EQ(std::string("Param"), prefs()->GetInstallParam(id_));
621 624
622 const base::DictionaryValue* manifest; 625 const base::DictionaryValue* manifest;
623 ASSERT_TRUE(prefs()->ReadPrefAsDictionary(id_, "manifest", &manifest)); 626 ASSERT_TRUE(prefs()->ReadPrefAsDictionary(id_, "manifest", &manifest));
624 ASSERT_TRUE(manifest); 627 ASSERT_TRUE(manifest);
625 std::string value; 628 std::string value;
626 EXPECT_TRUE(manifest->GetString(manifest_keys::kName, &value)); 629 EXPECT_TRUE(manifest->GetString(manifest_keys::kName, &value));
627 EXPECT_EQ("test", value); 630 EXPECT_EQ("test", value);
628 EXPECT_TRUE(manifest->GetString(manifest_keys::kVersion, &value)); 631 EXPECT_TRUE(manifest->GetString(manifest_keys::kVersion, &value));
629 EXPECT_EQ("0.2", value); 632 EXPECT_EQ("0.2", value);
630 EXPECT_FALSE(manifest->GetString(manifest_keys::kBackgroundPage, &value)); 633 EXPECT_FALSE(manifest->GetString(manifest_keys::kBackgroundPage, &value));
631 const base::ListValue* scripts; 634 const base::ListValue* scripts;
632 ASSERT_TRUE(manifest->GetList(manifest_keys::kBackgroundScripts, &scripts)); 635 ASSERT_TRUE(manifest->GetList(manifest_keys::kBackgroundScripts, &scripts));
633 EXPECT_EQ(1u, scripts->GetSize()); 636 EXPECT_EQ(1u, scripts->GetSize());
634 } 637 }
635 638
636 protected: 639 protected:
637 std::string id_; 640 std::string id_;
638 }; 641 };
639 TEST_F(ExtensionPrefsFinishDelayedInstallInfo, FinishDelayedInstallInfo) {} 642 TEST_F(ExtensionPrefsFinishDelayedInstallInfo, FinishDelayedInstallInfo) {}
640 643
641 class ExtensionPrefsOnExtensionInstalled : public ExtensionPrefsTest { 644 class ExtensionPrefsOnExtensionInstalled : public ExtensionPrefsTest {
642 public: 645 public:
643 virtual void Initialize() OVERRIDE { 646 virtual void Initialize() OVERRIDE {
644 extension_ = prefs_.AddExtension("on_extension_installed"); 647 extension_ = prefs_.AddExtension("on_extension_installed");
645 EXPECT_FALSE(prefs()->IsExtensionDisabled(extension_->id())); 648 EXPECT_FALSE(prefs()->IsExtensionDisabled(extension_->id()));
646 prefs()->OnExtensionInstalled(extension_.get(), 649 prefs()->OnExtensionInstalled(extension_.get(),
647 Extension::DISABLED, 650 Extension::DISABLED,
648 false, 651 false,
649 syncer::StringOrdinal()); 652 syncer::StringOrdinal(),
653 "Param");
650 } 654 }
651 655
652 virtual void Verify() OVERRIDE { 656 virtual void Verify() OVERRIDE {
653 EXPECT_TRUE(prefs()->IsExtensionDisabled(extension_->id())); 657 EXPECT_TRUE(prefs()->IsExtensionDisabled(extension_->id()));
658 EXPECT_EQ(std::string("Param"), prefs()->GetInstallParam(extension_->id()));
654 } 659 }
655 660
656 private: 661 private:
657 scoped_refptr<Extension> extension_; 662 scoped_refptr<Extension> extension_;
658 }; 663 };
659 TEST_F(ExtensionPrefsOnExtensionInstalled, 664 TEST_F(ExtensionPrefsOnExtensionInstalled,
660 ExtensionPrefsOnExtensionInstalled) {} 665 ExtensionPrefsOnExtensionInstalled) {}
661 666
662 class ExtensionPrefsAppDraggedByUser : public ExtensionPrefsTest { 667 class ExtensionPrefsAppDraggedByUser : public ExtensionPrefsTest {
663 public: 668 public:
664 virtual void Initialize() OVERRIDE { 669 virtual void Initialize() OVERRIDE {
665 extension_ = prefs_.AddExtension("on_extension_installed"); 670 extension_ = prefs_.AddExtension("on_extension_installed");
666 EXPECT_FALSE(prefs()->WasAppDraggedByUser(extension_->id())); 671 EXPECT_FALSE(prefs()->WasAppDraggedByUser(extension_->id()));
667 prefs()->OnExtensionInstalled(extension_.get(), 672 prefs()->OnExtensionInstalled(extension_.get(),
668 Extension::ENABLED, 673 Extension::ENABLED,
669 false, 674 false,
670 syncer::StringOrdinal()); 675 syncer::StringOrdinal(),
676 std::string());
671 } 677 }
672 678
673 virtual void Verify() OVERRIDE { 679 virtual void Verify() OVERRIDE {
674 // Set the flag and see if it persisted. 680 // Set the flag and see if it persisted.
675 prefs()->SetAppDraggedByUser(extension_->id()); 681 prefs()->SetAppDraggedByUser(extension_->id());
676 EXPECT_TRUE(prefs()->WasAppDraggedByUser(extension_->id())); 682 EXPECT_TRUE(prefs()->WasAppDraggedByUser(extension_->id()));
677 683
678 // Make sure it doesn't change on consecutive calls. 684 // Make sure it doesn't change on consecutive calls.
679 prefs()->SetAppDraggedByUser(extension_->id()); 685 prefs()->SetAppDraggedByUser(extension_->id());
680 EXPECT_TRUE(prefs()->WasAppDraggedByUser(extension_->id())); 686 EXPECT_TRUE(prefs()->WasAppDraggedByUser(extension_->id()));
(...skipping 208 matching lines...) Expand 10 before | Expand all | Expand 10 after
889 EXPECT_FALSE(prefs()->IsExtensionBlacklisted(extension_a_->id())); 895 EXPECT_FALSE(prefs()->IsExtensionBlacklisted(extension_a_->id()));
890 EXPECT_EQ(empty_ids, prefs()->GetBlacklistedExtensions()); 896 EXPECT_EQ(empty_ids, prefs()->GetBlacklistedExtensions());
891 } 897 }
892 898
893 private: 899 private:
894 scoped_refptr<const Extension> extension_a_; 900 scoped_refptr<const Extension> extension_a_;
895 }; 901 };
896 TEST_F(ExtensionPrefsBlacklistState, ExtensionPrefsBlacklistState) {} 902 TEST_F(ExtensionPrefsBlacklistState, ExtensionPrefsBlacklistState) {}
897 903
898 } // namespace extensions 904 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698