Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Unified Diff: slave/skia_slave_scripts/build_step.py

Issue 196653010: Reads bench expectations from skia-autogen svn repo. (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: slave/skia_slave_scripts/build_step.py
diff --git a/slave/skia_slave_scripts/build_step.py b/slave/skia_slave_scripts/build_step.py
index f0c2f6f15d8b8cc27d7af20130829d9cd18434e0..2b5460d553145f59332984bdace72894be369fee 100644
--- a/slave/skia_slave_scripts/build_step.py
+++ b/slave/skia_slave_scripts/build_step.py
@@ -210,15 +210,21 @@ class BuildStep(multiprocessing.Process):
self._skp_dir = self._local_playback_dirs.PlaybackSkpDir()
- # Figure out where we are going to store performance output.
+ # Figure out where we are going to store performance related data.
if args['perf_output_basedir'] != 'None':
self._perf_data_dir = os.path.join(args['perf_output_basedir'],
self._builder_name, 'data')
self._perf_graphs_dir = os.path.join(args['perf_output_basedir'],
self._builder_name, 'graphs')
+ self._perf_range_input_dir = os.path.join(
+ args['perf_output_basedir'], self._builder_name, 'expectations')
+ self._perf_range_autogen_upload_dir = os.path.join(
+ args['perf_output_basedir'], self._builder_name, 'autogen_upload')
borenet 2014/03/13 20:45:37 These will soon be used by other steps than check_
benchen 2014/03/14 01:41:10 Yes, it's clearer that way. Deleted perf_range_aut
else:
self._perf_data_dir = None
self._perf_graphs_dir = None
+ self._perf_range_input_dir = None
+ self._perf_range_autogen_upload_dir = None
self._skimage_in_dir = os.path.join(os.pardir, 'skimage_in')
« no previous file with comments | « no previous file | slave/skia_slave_scripts/check_for_regressions.py » ('j') | slave/skia_slave_scripts/check_for_regressions.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698