Reads bench expectations from skia-autogen svn repo.

slave/skia_slave_scripts/build_step.py

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Base class for all slave-side build steps. """
 
 import config
 # pylint: disable=W0611
 import flavor_utils
 import imp
@@ skipping 192 matching lines @@
         self._builder_name,
         None if args['perf_output_basedir'] == 'None'
             else args['perf_output_basedir'])
     self._storage_playback_dirs = StorageSkpPlaybackDirs(
         self._builder_name,
         None if args['perf_output_basedir'] == 'None'
             else args['perf_output_basedir'])
 
     self._skp_dir = self._local_playback_dirs.PlaybackSkpDir()
 
-    # Figure out where we are going to store performance output.
+    # Figure out where we are going to store performance related data.
     if args['perf_output_basedir'] != 'None':
       self._perf_data_dir = os.path.join(args['perf_output_basedir'],
                                          self._builder_name, 'data')
       self._perf_graphs_dir = os.path.join(args['perf_output_basedir'],
                                            self._builder_name, 'graphs')
+      self._perf_range_input_dir = os.path.join(
+          args['perf_output_basedir'], self._builder_name, 'expectations')
+      self._perf_range_autogen_upload_dir = os.path.join(
+          args['perf_output_basedir'], self._builder_name, 'autogen_upload')

[borenet, 2014/03/13 20:45:37]

These will soon be used by other steps than check_for_regressions, right?  If
not, we should put them in that step.

[benchen, 2014/03/14 01:41:10]

Yes, it's clearer that way. Deleted perf_range_autogen_upload_dir for now.
On 2014/03/13 20:45:37, borenet wrote:

     else:
       self._perf_data_dir = None
       self._perf_graphs_dir = None
+      self._perf_range_input_dir = None
+      self._perf_range_autogen_upload_dir = None
 
     self._skimage_in_dir = os.path.join(os.pardir, 'skimage_in')
 
     self._skimage_expected_dir = os.path.join('expectations', 'skimage')
 
     self._skimage_out_dir = os.path.join('out', self._configuration,
                                          'skimage_out')
 
     self._device_dirs = self._flavor_utils.GetDeviceDirs()
 
@@ skipping 144 matching lines @@
         else:
           raise BuildStepFailure('Build step failed.')
       except Exception:
         print traceback.format_exc()
         if attempt + 1 >= step.attempts:
           raise
       # pylint: disable=W0212
       step._WaitFunc(attempt)
       attempt += 1
       print '**** %s, attempt %d ****' % (StepType.__name__, attempt + 1)