Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 196653009: Remove uses of RangeCanInclude() in flooring division by power of 2. (Closed)

Created:
6 years, 9 months ago by Benedikt Meurer
Modified:
6 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Remove uses of RangeCanInclude() in flooring division by power of 2. Drive-By-Fix: Improve ARM code generation for flooring division by power of 2. BUG=v8:3204 LOG=y R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19877

Patch Set 1 #

Patch Set 2 : RangeCanInclude() is gone now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -61 lines) Patch
M src/a64/lithium-a64.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M src/a64/lithium-codegen-a64.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +10 lines, -12 lines 0 comments Download
M src/hydrogen-instructions.h View 1 4 chunks +2 lines, -6 lines 0 comments Download
M src/hydrogen-instructions.cc View 2 chunks +22 lines, -6 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
6 years, 9 months ago (2014-03-13 07:09:15 UTC) #1
Sven Panne
lgtm
6 years, 9 months ago (2014-03-13 07:33:20 UTC) #2
Benedikt Meurer
6 years, 9 months ago (2014-03-13 07:59:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19877 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698