Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 196653009: Remove uses of RangeCanInclude() in flooring division by power of 2. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: RangeCanInclude() is gone now Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1312 matching lines...) Expand 10 before | Expand all | Expand 10 after
1323 return DoArithmeticD(Token::DIV, instr); 1323 return DoArithmeticD(Token::DIV, instr);
1324 } else { 1324 } else {
1325 return DoArithmeticT(Token::DIV, instr); 1325 return DoArithmeticT(Token::DIV, instr);
1326 } 1326 }
1327 } 1327 }
1328 1328
1329 1329
1330 LInstruction* LChunkBuilder::DoFlooringDivByPowerOf2I(HMathFloorOfDiv* instr) { 1330 LInstruction* LChunkBuilder::DoFlooringDivByPowerOf2I(HMathFloorOfDiv* instr) {
1331 LOperand* dividend = UseRegisterAtStart(instr->left()); 1331 LOperand* dividend = UseRegisterAtStart(instr->left());
1332 int32_t divisor = instr->right()->GetInteger32Constant(); 1332 int32_t divisor = instr->right()->GetInteger32Constant();
1333 LInstruction* result = 1333 LInstruction* result = DefineSameAsFirst(new(zone()) LFlooringDivByPowerOf2I(
1334 DefineSameAsFirst(new(zone()) LFlooringDivByPowerOf2I(dividend, divisor)); 1334 dividend, divisor));
1335 bool can_deopt = 1335 if ((instr->CheckFlag(HValue::kBailoutOnMinusZero) && divisor < 0) ||
1336 (instr->CheckFlag(HValue::kBailoutOnMinusZero) && divisor < 0) || 1336 (instr->CheckFlag(HValue::kLeftCanBeMinInt) && divisor == -1)) {
1337 (instr->left()->RangeCanInclude(kMinInt) && divisor == -1); 1337 result = AssignEnvironment(result);
1338 return can_deopt ? AssignEnvironment(result) : result; 1338 }
1339 return result;
1339 } 1340 }
1340 1341
1341 1342
1342 LInstruction* LChunkBuilder::DoFlooringDivByConstI(HMathFloorOfDiv* instr) { 1343 LInstruction* LChunkBuilder::DoFlooringDivByConstI(HMathFloorOfDiv* instr) {
1343 ASSERT(instr->representation().IsInteger32()); 1344 ASSERT(instr->representation().IsInteger32());
1344 ASSERT(instr->left()->representation().Equals(instr->representation())); 1345 ASSERT(instr->left()->representation().Equals(instr->representation()));
1345 ASSERT(instr->right()->representation().Equals(instr->representation())); 1346 ASSERT(instr->right()->representation().Equals(instr->representation()));
1346 LOperand* dividend = UseRegister(instr->left()); 1347 LOperand* dividend = UseRegister(instr->left());
1347 int32_t divisor = instr->right()->GetInteger32Constant(); 1348 int32_t divisor = instr->right()->GetInteger32Constant();
1348 LOperand* temp1 = FixedTemp(rax); 1349 LOperand* temp1 = FixedTemp(rax);
(...skipping 1170 matching lines...) Expand 10 before | Expand all | Expand 10 after
2519 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2520 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2520 LOperand* object = UseRegister(instr->object()); 2521 LOperand* object = UseRegister(instr->object());
2521 LOperand* index = UseTempRegister(instr->index()); 2522 LOperand* index = UseTempRegister(instr->index());
2522 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2523 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2523 } 2524 }
2524 2525
2525 2526
2526 } } // namespace v8::internal 2527 } } // namespace v8::internal
2527 2528
2528 #endif // V8_TARGET_ARCH_X64 2529 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698